Changeset 60135

Timestamp:

04/07/2025 10:13:27 PM (3 weeks ago)

Author:

peterwilsoncc

Message:

Site Editor: Fix PHP warning in _wp_get_site_editor_redirection_url().

Fixes a PHP Warning for an undefined array key "QUERY_STRING" in _wp_get_site_editor_redirection_url() in some PHP configurations.

Depending on the configuration, $_SERVER['QUERY_STRING'] can either be unset or an empty string when no query string included in the URL. This changes the condition from a falsey check to an empty() check.

Reviewed by Mamaduka.
Merges [60134] to the 6.8 branch.

Props akshaydhere, dilipbheda, johnbillion, rainynewt, sabernhardt, sainathpoojary, shovan_jaya, tusharaddweb, wildworks.
Fixes #63224.

Location:

branches/6.8

Files:

• . (modified) (1 prop)
• src/wp-admin/site-editor.php (modified) (1 diff)

branches/6.8/src/wp-admin/site-editor.php

@@ -32 +32 @@
 function _wp_get_site_editor_redirection_url() {
     global $pagenow;
-    if ( 'site-editor.php' !== $pagenow || isset( $_REQUEST['p'] ) || ! $_SERVER['QUERY_STRING'] ) {
+    if ( 'site-editor.php' !== $pagenow || isset( $_REQUEST['p'] ) || empty( $_SERVER['QUERY_STRING'] ) ) {
         return false;
     }