WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
04/09/2025 01:29:39 PM (6 weeks ago)
Author:
SergeyBiryukov
Message:

Tests: Use the ms-required group where appropriate.

This replaces the if ( is_multisite() ) conditional wrapping entire test classes with the ms-required group for more consistency across the test suite.

Follow-up to [40520].

See #63167.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/multisite/uploadIsUserOverQuota.php

    r51869 r60148  
    11<?php
    22
    3 if ( is_multisite() ) :
     3/**
     4 * Tests specific to `upload_is_user_over_quota()` in multisite.
     5 *
     6 * These tests filter `get_space_allowed` and `pre_get_space_used` in
     7 * most cases as those are tested elsewhere.
     8 *
     9 * @group ms-required
     10 * @group multisite
     11 */
     12class Tests_Multisite_UploadIsUserOverQuota extends WP_UnitTestCase {
     13
     14    public function set_up() {
     15        parent::set_up();
     16        update_site_option( 'upload_space_check_disabled', false );
     17    }
     18
     19    public function test_upload_is_user_over_quota_allowed_0_used_5() {
     20        add_filter( 'get_space_allowed', '__return_zero' );
     21        add_filter( 'pre_get_space_used', array( $this, '_filter_space_5' ) );
     22        $result = upload_is_user_over_quota( false );
     23        remove_filter( 'get_space_allowed', '__return_zero' );
     24        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_5' ) );
     25
     26        $this->assertTrue( $result );
     27    }
     28
     29    public function test_upload_is_user_over_quota_allowed_0_used_0() {
     30        add_filter( 'get_space_allowed', '__return_zero' );
     31        add_filter( 'pre_get_space_used', '__return_zero' );
     32        $result = upload_is_user_over_quota( false );
     33        remove_filter( 'get_space_allowed', '__return_zero' );
     34        remove_filter( 'pre_get_space_used', '__return_zero' );
     35
     36        $this->assertFalse( $result );
     37    }
     38
     39    public function test_upload_is_user_over_quota_allowed_0_used_100() {
     40        add_filter( 'get_space_allowed', '__return_zero' );
     41        add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     42        $result = upload_is_user_over_quota( false );
     43        remove_filter( 'get_space_allowed', '__return_zero' );
     44        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     45
     46        $this->assertTrue( $result );
     47    }
     48
     49    public function test_upload_is_user_over_quota_allowed_100_used_0() {
     50        add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     51        add_filter( 'pre_get_space_used', '__return_zero' );
     52        $result = upload_is_user_over_quota( false );
     53        remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     54        remove_filter( 'pre_get_space_used', '__return_zero' );
     55
     56        $this->assertFalse( $result );
     57    }
     58
     59    public function test_upload_is_user_over_quota_allowed_100_used_100() {
     60        add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     61        add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     62        $result = upload_is_user_over_quota( false );
     63        remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     64        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     65
     66        $this->assertFalse( $result );
     67    }
     68
     69    public function test_upload_is_user_over_quota_allowed_100_used_200() {
     70        add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     71        add_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
     72        $result = upload_is_user_over_quota( false );
     73        remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     74        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
     75
     76        $this->assertTrue( $result );
     77    }
     78
     79    public function test_upload_is_user_over_quota_allowed_negative_used_100() {
     80        add_filter( 'get_space_allowed', array( $this, '_filter_space_negative' ) );
     81        add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     82        $result = upload_is_user_over_quota( false );
     83        remove_filter( 'get_space_allowed', array( $this, '_filter_space_negative' ) );
     84        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
     85
     86        $this->assertTrue( $result );
     87    }
    488
    589    /**
    6      * Tests specific to `upload_is_user_over_quota()` in multisite.
    7      *
    8      * These tests filter `get_space_allowed` and `pre_get_space_used` in
    9      * most cases as those are tested elsewhere.
    10      *
    11      * @group multisite
     90     * When the upload space check is disabled, using more than the available
     91     * quota is allowed.
    1292     */
    13     class Tests_Multisite_UploadIsUserOverQuota extends WP_UnitTestCase {
     93    public function test_upload_is_user_over_check_disabled() {
     94        update_site_option( 'upload_space_check_disabled', true );
    1495
    15         public function set_up() {
    16             parent::set_up();
    17             update_site_option( 'upload_space_check_disabled', false );
    18         }
     96        add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     97        add_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
     98        $result = upload_is_user_over_quota( false );
     99        remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
     100        remove_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
    19101
    20         public function test_upload_is_user_over_quota_allowed_0_used_5() {
    21             add_filter( 'get_space_allowed', '__return_zero' );
    22             add_filter( 'pre_get_space_used', array( $this, '_filter_space_5' ) );
    23             $result = upload_is_user_over_quota( false );
    24             remove_filter( 'get_space_allowed', '__return_zero' );
    25             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_5' ) );
    26 
    27             $this->assertTrue( $result );
    28         }
    29 
    30         public function test_upload_is_user_over_quota_allowed_0_used_0() {
    31             add_filter( 'get_space_allowed', '__return_zero' );
    32             add_filter( 'pre_get_space_used', '__return_zero' );
    33             $result = upload_is_user_over_quota( false );
    34             remove_filter( 'get_space_allowed', '__return_zero' );
    35             remove_filter( 'pre_get_space_used', '__return_zero' );
    36 
    37             $this->assertFalse( $result );
    38         }
    39 
    40         public function test_upload_is_user_over_quota_allowed_0_used_100() {
    41             add_filter( 'get_space_allowed', '__return_zero' );
    42             add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    43             $result = upload_is_user_over_quota( false );
    44             remove_filter( 'get_space_allowed', '__return_zero' );
    45             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    46 
    47             $this->assertTrue( $result );
    48         }
    49 
    50         public function test_upload_is_user_over_quota_allowed_100_used_0() {
    51             add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    52             add_filter( 'pre_get_space_used', '__return_zero' );
    53             $result = upload_is_user_over_quota( false );
    54             remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    55             remove_filter( 'pre_get_space_used', '__return_zero' );
    56 
    57             $this->assertFalse( $result );
    58         }
    59 
    60         public function test_upload_is_user_over_quota_allowed_100_used_100() {
    61             add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    62             add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    63             $result = upload_is_user_over_quota( false );
    64             remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    65             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    66 
    67             $this->assertFalse( $result );
    68         }
    69 
    70         public function test_upload_is_user_over_quota_allowed_100_used_200() {
    71             add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    72             add_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
    73             $result = upload_is_user_over_quota( false );
    74             remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    75             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
    76 
    77             $this->assertTrue( $result );
    78         }
    79 
    80         public function test_upload_is_user_over_quota_allowed_negative_used_100() {
    81             add_filter( 'get_space_allowed', array( $this, '_filter_space_negative' ) );
    82             add_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    83             $result = upload_is_user_over_quota( false );
    84             remove_filter( 'get_space_allowed', array( $this, '_filter_space_negative' ) );
    85             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_100' ) );
    86 
    87             $this->assertTrue( $result );
    88         }
    89 
    90         /**
    91          * When the upload space check is disabled, using more than the available
    92          * quota is allowed.
    93          */
    94         public function test_upload_is_user_over_check_disabled() {
    95             update_site_option( 'upload_space_check_disabled', true );
    96 
    97             add_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    98             add_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
    99             $result = upload_is_user_over_quota( false );
    100             remove_filter( 'get_space_allowed', array( $this, '_filter_space_100' ) );
    101             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_200' ) );
    102 
    103             $this->assertFalse( $result );
    104         }
    105 
    106         public function _filter_space_5() {
    107             return 5;
    108         }
    109 
    110         public function _filter_space_100() {
    111             return 100;
    112         }
    113 
    114         public function _filter_space_200() {
    115             return 200;
    116         }
    117 
    118         public function _filter_space_negative() {
    119             return -1;
    120         }
     102        $this->assertFalse( $result );
    121103    }
    122104
    123 endif;
     105    public function _filter_space_5() {
     106        return 5;
     107    }
     108
     109    public function _filter_space_100() {
     110        return 100;
     111    }
     112
     113    public function _filter_space_200() {
     114        return 200;
     115    }
     116
     117    public function _filter_space_negative() {
     118        return -1;
     119    }
     120}
Note: See TracChangeset for help on using the changeset viewer.