Changeset 60153

Timestamp:

04/13/2025 04:46:50 PM (2 weeks ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Check for an empty address first on admin email change notification.

This follows a common best practice of checking for an empty value before doing a specific comparison.

Follow-up to [60122], [60129].

Props dilipbheda, Presskopp.
Fixes #63267.

Location:

trunk/src/wp-includes

Files:

• functions.php (modified) (1 diff)
• ms-functions.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -8123 +8123 @@
     $send = true;
 
-    // Don't send the notification to the default 'admin_email' value or an empty value.
-    if ( 'you@example.com' === $old_email || empty( $old_email ) ) {
+    // Don't send the notification for an empty email address or the default 'admin_email' value.
+    if ( empty( $old_email ) || 'you@example.com' === $old_email ) {
         $send = false;
     }

trunk/src/wp-includes/ms-functions.php

@@ -2870 +2870 @@
     $send = true;
 
-    // Don't send the notification to the default 'admin_email' value or an empty value.
-    if ( 'you@example.com' === $old_email || empty( $old_email ) ) {
+    // Don't send the notification for an empty email address or the default 'admin_email' value.
+    if ( empty( $old_email ) || 'you@example.com' === $old_email ) {
         $send = false;
     }