Changeset 60184

Timestamp:

04/24/2025 11:16:41 PM (7 months ago)

Author:

jorbin

Message:

Upgrade/Install: Pass stored credentials to WP_Filesystem() in WP_Upgrader.

When using a non-direct filesystem, the call in WP_Upgrader::maintenance_mode() did not include the required credentials, leading to a fatal error as the connection was not initialized properly.

This commit attempts to use the stored credentials if available, and triggers a notice otherwise.

Follow-up to [56341], [58128].

Reviewed by jorbin.
Merges [60107] to the 6.8 branch.

Props SirLouen, hideishi, dd32, tusharaddweb, takuword, SergeyBiryukov.
Fixes #62718.

Location:

branches/6.8

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-upgrader.php (modified) (1 diff)

branches/6.8/src/wp-admin/includes/class-wp-upgrader.php

@@ -1009 +1009 @@
 
         if ( ! $wp_filesystem ) {
-            require_once ABSPATH . 'wp-admin/includes/file.php';
-            WP_Filesystem();
+            if ( ! function_exists( 'WP_Filesystem' ) ) {
+                require_once ABSPATH . 'wp-admin/includes/file.php';
+            }
+
+            ob_start();
+            $credentials = request_filesystem_credentials( '' );
+            ob_end_clean();
+
+            if ( false === $credentials || ! WP_Filesystem( $credentials ) ) {
+                wp_trigger_error( __FUNCTION__, __( 'Could not access filesystem.' ) );
+                return;
+            }
         }