Changeset 60186 for trunk

Timestamp:

04/25/2025 06:19:01 PM (15 months ago)

Author:

joedolson

Message:

Themes: Add filter on bulk action fields.

Because validation was added in [59134] to prevent submitting bulk actions with no selected action, sites that remove or change the default bulk actions can fail due to the missing required inputs. Add a filter (bulk_action_observer_ids) that allows modifying the actions accepted to fulfill validation rules.

Props ethitter, kabir93, jorbin, davidbaumwald, joedolson.
Fixes #63005.

Location:

trunk/src

Files:

• js/_enqueues/admin/common.js (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/js/_enqueues/admin/common.js

@@ -1328 +1328 @@
                 // Observe submissions from posts lists for 'bulk_action' or users lists for 'new_role'.
                 var bulkFieldRelations = {
-                        'bulk_action' : 'action',
-                        'changeit' : 'new_role'
+                        'bulk_action' : window.bulkActionObserverIds.bulk_action,
+                        'changeit' : window.bulkActionObserverIds.changeit
                 };
                 if ( ! Object.keys( bulkFieldRelations ).includes( submitterName ) ) {

trunk/src/wp-includes/script-loader.php

@@ -757 +757 @@
         $scripts->add( 'common', "/wp-admin/js/common$suffix.js", array( 'jquery', 'hoverIntent', 'utils', 'wp-a11y' ), false, 1 );
         $scripts->set_translations( 'common' );
+
+        $bulk_action_observer_ids = array(
+                'bulk_action' => 'action',
+                'changeit'    => 'new_role',
+        );
+        did_action( 'init' ) && $scripts->localize(
+                'common',
+                'bulkActionObserverIds',
+                /**
+                 * Filters the array of field name attributes for bulk actions.
+                 *
+                 * @since 6.8.1
+                 *
+                 * @param array $bulk_action_observer_ids {
+                 *      An array of field name attributes for bulk actions.
+                 *
+                 *      @type string $bulk_action The bulk action field name. Default 'action'.
+                 *      @type string $changeit    The new role field name. Default 'new_role'.
+                 * }
+                 */
+                apply_filters( 'bulk_action_observer_ids', $bulk_action_observer_ids )
+        );
 
         $scripts->add( 'wp-sanitize', "/wp-includes/js/wp-sanitize$suffix.js", array(), false, 1 );