Changeset 60187

Timestamp:

04/25/2025 06:26:40 PM (4 weeks ago)

Author:

joedolson

Message:

Editor: Use different keys in array of translatable strings.

[59696] changed the 'Text' tab of the classic editor to 'Code' but Code was already used as a key in the array of translatable text. Since arrays keys need to be unique, this meant that it is possible for the wrong translation to appear in a locale. Using different keys fixes that.

Reviewed by joedolson.
Merges [60182] to the 6.8 branch.

Props joedolson, sabernhardt, justlevine, swissspidy, audrasjb.
Fixes #63269. See #38061.

Location:

branches/6.8

Files:

• . (modified) (1 prop)
• src/js/_enqueues/wp/editor/base.js (modified) (1 diff)
• src/wp-includes/class-wp-editor.php (modified) (1 diff)

branches/6.8/src/js/_enqueues/wp/editor/base.js

@@ -1294 +1294 @@
                             id: id + '-html',
                             'class': 'wp-switch-editor switch-html'
-                        }).text( window.tinymce.translate( 'Code' ) ) )
+                        }).text( window.tinymce.translate( 'Code|tab' ) ) )
                     ).append( $editorContainer )
             );

branches/6.8/src/wp-includes/class-wp-editor.php

@@ -1397 +1397 @@
                 'Link options'                         => __( 'Link options' ), // Tooltip for the 'link options' button in the inline link dialog.
                 'Visual'                               => _x( 'Visual', 'Name for the Visual editor tab' ),             // Editor switch tab label.
-                'Code'                                 => _x( 'Code', 'Name for the Code editor tab (formerly Text)' ), // Editor switch tab label.
+                'Code|tab'                             => _x( 'Code', 'Name for the Code editor tab (formerly Text)' ), // Editor switch tab label.
                 'Add Media'                            => array( __( 'Add Media' ), 'accessM' ), // Tooltip for the 'Add Media' button in the block editor Classic block.