Changeset 60203

Timestamp:

04/28/2025 08:49:19 PM (17 months ago)

Author:

flixos90

Message:

Query: Avoid unnecessary database query when deleting a font family.

Querying only the font face IDs is sufficient when deleting a font family. There is no need to warm the caches with the full objects, since wp_delete_post() will always make a direct database query to get the object anyway.

Props dilipbheda.
Fixes #63014.

File:

• trunk/src/wp-includes/fonts.php (modified) (1 diff)

trunk/src/wp-includes/fonts.php

@@ -220 +220 @@
         }
 
-        $font_faces = get_children(
+        $font_faces_ids = get_children(
                 array(
                         'post_parent' => $post_id,
                         'post_type'   => 'wp_font_face',
+                        'fields'      => 'ids',
                 )
         );
 
-        foreach ( $font_faces as $font_face ) {
-                wp_delete_post( $font_face->ID, true );
+        foreach ( $font_faces_ids as $font_faces_id ) {
+                wp_delete_post( $font_faces_id, true );
         }
 }