Changeset 60251 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

05/26/2025 12:03:18 PM (10 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions that test the tests.

Several tests perform assertions conditionally or iterate dynamic arrays without ensuring they're populated. If the test is faulty and the condition never evaluates to true, or the array being iterated is unexpectedly empty, this will now correctly cause the test to fail.

Props johnbillion, jrf.

See #63167

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (1 diff)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -767 +767 @@
 
         $post_types = get_post_types( array( 'show_in_nav_menus' => true ), 'object' );
-        if ( $post_types ) {
-            foreach ( $post_types as $type ) {
-                $this->assertStringContainsString( 'available-menu-items-post_type-' . esc_attr( $type->name ), $template );
-                $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $type->labels->name ) . '#', $template );
-                $this->assertStringContainsString( 'data-type="post_type"', $template );
-                $this->assertStringContainsString( 'data-object="' . esc_attr( $type->name ) . '"', $template );
-                $this->assertStringContainsString( 'data-type_label="' . esc_attr( $type->labels->singular_name ) . '"', $template );
-            }
+
+        $this->assertNotEmpty( $post_types );
+
+        foreach ( $post_types as $type ) {
+            $this->assertStringContainsString( 'available-menu-items-post_type-' . esc_attr( $type->name ), $template );
+            $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $type->labels->name ) . '#', $template );
+            $this->assertStringContainsString( 'data-type="post_type"', $template );
+            $this->assertStringContainsString( 'data-object="' . esc_attr( $type->name ) . '"', $template );
+            $this->assertStringContainsString( 'data-type_label="' . esc_attr( $type->labels->singular_name ) . '"', $template );
         }
 
         $taxonomies = get_taxonomies( array( 'show_in_nav_menus' => true ), 'object' );
-        if ( $taxonomies ) {
-            foreach ( $taxonomies as $tax ) {
-                $this->assertStringContainsString( 'available-menu-items-taxonomy-' . esc_attr( $tax->name ), $template );
-                $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $tax->labels->name ) . '#', $template );
-                $this->assertStringContainsString( 'data-type="taxonomy"', $template );
-                $this->assertStringContainsString( 'data-object="' . esc_attr( $tax->name ) . '"', $template );
-                $this->assertStringContainsString( 'data-type_label="' . esc_attr( $tax->labels->singular_name ) . '"', $template );
-            }
+
+        $this->assertNotEmpty( $taxonomies );
+
+        foreach ( $taxonomies as $tax ) {
+            $this->assertStringContainsString( 'available-menu-items-taxonomy-' . esc_attr( $tax->name ), $template );
+            $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $tax->labels->name ) . '#', $template );
+            $this->assertStringContainsString( 'data-type="taxonomy"', $template );
+            $this->assertStringContainsString( 'data-object="' . esc_attr( $tax->name ) . '"', $template );
+            $this->assertStringContainsString( 'data-type_label="' . esc_attr( $tax->labels->singular_name ) . '"', $template );
         }