Changeset 60251 for trunk/tests/phpunit/tests/term/meta.php

Timestamp:

05/26/2025 12:03:18 PM (9 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions that test the tests.

Several tests perform assertions conditionally or iterate dynamic arrays without ensuring they're populated. If the test is faulty and the condition never evaluates to true, or the array being iterated is unexpectedly empty, this will now correctly cause the test to fail.

Props johnbillion, jrf.

See #63167

File:

• trunk/tests/phpunit/tests/term/meta.php (modified) (2 diffs)

trunk/tests/phpunit/tests/term/meta.php

@@ -133 +133 @@
         remove_action( 'pre_get_posts', array( $this, 'set_cache_results' ) );
 
-        if ( have_posts() ) {
-            while ( have_posts() ) {
-                the_post();
-
-                // First request will hit the database.
-                $num_queries = get_num_queries();
-                $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
-                ++$num_queries;
-                $this->assertSame( $num_queries, get_num_queries() );
-
-                // Second and third requests should be in cache.
-                $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
-                $this->assertSame( 'bar', get_term_meta( $terms[2], 'foo', true ) );
-                $this->assertSame( $num_queries, get_num_queries() );
-
-                // Querying a term not primed should result in a hit.
-                ++$num_queries;
-                $this->assertSame( 'bar', get_term_meta( $orphan_term, 'foo', true ) );
-                $this->assertSame( $num_queries, get_num_queries() );
-            }
+        $this->assertTrue( have_posts() );
+
+        while ( have_posts() ) {
+            the_post();
+
+            // First request will hit the database.
+            $num_queries = get_num_queries();
+            $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
+            ++$num_queries;
+            $this->assertSame( $num_queries, get_num_queries() );
+
+            // Second and third requests should be in cache.
+            $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
+            $this->assertSame( 'bar', get_term_meta( $terms[2], 'foo', true ) );
+            $this->assertSame( $num_queries, get_num_queries() );
+
+            // Querying a term not primed should result in a hit.
+            ++$num_queries;
+            $this->assertSame( 'bar', get_term_meta( $orphan_term, 'foo', true ) );
+            $this->assertSame( $num_queries, get_num_queries() );
         }
     }
@@ -202 +202 @@
         );
 
-        if ( $q->have_posts() ) {
-            while ( $q->have_posts() ) {
-                $q->the_post();
-
-                // Requests will hit the database.
-                $num_queries = get_num_queries();
-                $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
-                ++$num_queries;
-                $this->assertSame( $num_queries, get_num_queries() );
-
-                $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
-                ++$num_queries;
-                $this->assertSame( $num_queries, get_num_queries() );
-            }
+        $this->assertTrue( $q->have_posts() );
+
+        while ( $q->have_posts() ) {
+            $q->the_post();
+
+            // Requests will hit the database.
+            $num_queries = get_num_queries();
+            $this->assertSame( 'bar', get_term_meta( $terms[0], 'foo', true ) );
+            ++$num_queries;
+            $this->assertSame( $num_queries, get_num_queries() );
+
+            $this->assertSame( 'bar', get_term_meta( $terms[1], 'foo', true ) );
+            ++$num_queries;
+            $this->assertSame( $num_queries, get_num_queries() );
         }
     }