Context Navigation

← Previous Change
Next Change →

getComments.php

Timestamp:

05/26/2025 12:03:18 PM (14 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Add assertions that test the tests.

Several tests perform assertions conditionally or iterate dynamic arrays without ensuring they're populated. If the test is faulty and the condition never evaluates to true, or the array being iterated is unexpectedly empty, this will now correctly cause the test to fail.

Props johnbillion, jrf.

See #63167

File:

: 1 edited

trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php

-              r52010
+              r60251
                 $results = $this->myxmlrpcserver->wp_getComments( array( 1, 'editor', 'editor', array() ) );
                 $this->assertNotIXRError( $results );
+                $this->assertNotEmpty( $results );
                 foreach ( $results as $result ) {
 …
                 );
                 $this->assertNotIXRError( $results );
+                $this->assertNotEmpty( $results );
                 foreach ( $results as $result ) {

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 60251 for trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php

Legend:

trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php

Download in other formats: