Changeset 60253 for trunk/tests/phpunit/tests/comment/wpHandleCommentSubmission.php

Timestamp:

05/26/2025 02:34:12 PM (10 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Increase shared user fixtures following switch to bcrypt hashing.

User creation is somewhat more expensive since switching the default password hashing algorithm to bcrypt in 6.8. This speeds up the tests by making more use of shared user fixtures, thus reducing the number of users that are created during tests.

Props peterwilsoncc.

See #63026

File:

• trunk/tests/phpunit/tests/comment/wpHandleCommentSubmission.php (modified) (7 diffs)

trunk/tests/phpunit/tests/comment/wpHandleCommentSubmission.php

@@ -10 +10 @@
     protected static $post;
     protected static $author_id;
+    protected static $author_id2;
     protected static $editor_id;
 
@@ -20 +21 @@
             array(
                 'role' => 'author',
+            )
+        );
+
+        self::$author_id2 = $factory->user->create(
+            array(
+                'role'     => 'author',
+                'user_url' => 'http://user.example.org',
             )
         );
@@ -224 +232 @@
     public function test_submitting_valid_comment_as_logged_in_user_succeeds() {
 
-        $user = self::factory()->user->create_and_get(
-            array(
-                'user_url' => 'http://user.example.org',
-            )
-        );
+        $user = get_user_by( 'id', self::$author_id2 );
 
         wp_set_current_user( $user->ID );
@@ -315 +319 @@
         $error = 'comment_id_not_found';
 
-        $user = self::factory()->user->create_and_get(
-            array(
-                'role' => 'author',
-            )
-        );
+        $user = get_user_by( 'id', self::$author_id2 );
 
         wp_set_current_user( $user->ID );
@@ -344 +344 @@
         $error = 'comment_id_not_found';
 
-        $user = self::factory()->user->create_and_get(
-            array(
-                'role' => 'author',
-            )
-        );
+        $user = get_user_by( 'id', self::$author_id2 );
 
         wp_set_current_user( $user->ID );
@@ -835 +831 @@
      * @ticket 36901
      */
-    public function test_comments_flood_user_is_admin() {
-        $user = self::factory()->user->create_and_get(
-            array(
-                'role' => 'administrator',
-            )
-        );
+    public function test_comments_flood_user_can_moderate_comments() {
+        $user = get_user_by( 'id', self::$editor_id );
         wp_set_current_user( $user->ID );
 
@@ -854 +846 @@
         $second_comment  = wp_handle_comment_submission( $data );
 
-        $this->assertNotWPError( $second_comment );
-        $this->assertSame( (string) self::$post->ID, $second_comment->comment_post_ID );
+        $this->assertTrue( current_user_can( 'moderate_comments' ), 'Test user should have the moderate_comments capability' );
+        $this->assertNotWPError( $second_comment, 'Second comment should not trigger comment flooding error.' );
+        $this->assertSame( (string) self::$post->ID, $second_comment->comment_post_ID, 'Second comment should be made against initial post.' );
     }