Changeset 60253 for trunk/tests/phpunit/tests/customize/manager.php

Timestamp:

05/26/2025 02:34:12 PM (9 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Increase shared user fixtures following switch to bcrypt hashing.

User creation is somewhat more expensive since switching the default password hashing algorithm to bcrypt in 6.8. This speeds up the tests by making more use of shared user fixtures, thus reducing the number of users that are created during tests.

Props peterwilsoncc.

See #63026

File:

• trunk/tests/phpunit/tests/customize/manager.php (modified) (8 diffs)

trunk/tests/phpunit/tests/customize/manager.php

@@ -28 +28 @@
 
     /**
+     * Second admin user ID.
+     *
+     * @var int
+     */
+    protected static $other_admin_user_id;
+
+    /**
      * Subscriber user ID.
      *
@@ -47 +54 @@
      */
     public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
-        self::$subscriber_user_id = $factory->user->create( array( 'role' => 'subscriber' ) );
-        self::$admin_user_id      = $factory->user->create( array( 'role' => 'administrator' ) );
+        self::$subscriber_user_id  = $factory->user->create( array( 'role' => 'subscriber' ) );
+        self::$admin_user_id       = $factory->user->create( array( 'role' => 'administrator' ) );
+        self::$other_admin_user_id = $factory->user->create( array( 'role' => 'administrator' ) );
     }
 
@@ -154 +162 @@
     public function test_constructor_deferred_changeset_uuid() {
         wp_set_current_user( self::$admin_user_id );
-        $other_admin_user_id = self::factory()->user->create( array( 'role' => 'admin' ) );
+        $other_admin_user_id = self::$other_admin_user_id;
 
         $data = array(
@@ -1255 +1263 @@
     public function test_save_changeset_post_without_kses_corrupting_json() {
         global $wp_customize;
-        $lesser_admin_user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
+        $lesser_admin_user_id = self::$other_admin_user_id;
 
         $uuid         = wp_generate_uuid4();
@@ -1500 +1508 @@
         add_theme_support( 'custom-background' );
         wp_set_current_user( self::$admin_user_id );
-        $other_admin_user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
+        $other_admin_user_id = self::$other_admin_user_id;
 
         $uuid         = wp_generate_uuid4();
@@ -1715 +1723 @@
         add_theme_support( 'custom-background' );
         wp_set_current_user( self::$admin_user_id );
-        $other_admin_user_id = self::factory()->user->create( array( 'role' => 'administrator' ) );
+        $other_admin_user_id = self::$other_admin_user_id;
 
         $uuid         = wp_generate_uuid4();
@@ -1878 +1886 @@
             array(
                 'autosave' => true,
-                'user_id'  => self::factory()->user->create( array( 'role' => 'administrator' ) ),
+                'user_id'  => self::$other_admin_user_id,
             )
         );
@@ -3010 +3018 @@
      */
     public function test_return_url() {
-        wp_set_current_user( self::factory()->user->create( array( 'role' => 'author' ) ) );
+        wp_set_current_user( self::$subscriber_user_id );
         $this->assertSame( home_url( '/' ), $this->manager->get_return_url() );