Changeset 60253 for trunk/tests/phpunit/tests/query/conditionals.php

Timestamp:

05/26/2025 02:34:12 PM (17 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Increase shared user fixtures following switch to bcrypt hashing.

User creation is somewhat more expensive since switching the default password hashing algorithm to bcrypt in 6.8. This speeds up the tests by making more use of shared user fixtures, thus reducing the number of users that are created during tests.

Props peterwilsoncc.

See #63026

File:

• trunk/tests/phpunit/tests/query/conditionals.php (modified) (9 diffs)

trunk/tests/phpunit/tests/query/conditionals.php

@@ -15 +15 @@
         protected $post_ids;
 
+        /**
+         * ID of the user-a.
+         *
+         * @var int
+         */
+        public static $user_a_id;
+
+        /**
+         * Set up the shared fixture.
+         *
+         * @param WP_UnitTest_Factory $factory Factory instance.
+         */
+        public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
+                self::$user_a_id = $factory->user->create( array( 'user_login' => 'user-a' ) );
+        }
+
         public function set_up() {
                 parent::set_up();
@@ -589 +605 @@
         // 'author/([^/]+)/(feed|rdf|rss|rss2|atom)/?$' => 'index.php?author_name=$matches[1]&feed=$matches[2]',
         public function test_author_feed() {
-                self::factory()->user->create( array( 'user_login' => 'user-a' ) );
                 // Check the long form.
                 $types = array( 'feed', 'rdf', 'rss', 'rss2', 'atom' );
@@ -608 +623 @@
         public function test_author_paged() {
                 update_option( 'posts_per_page', 2 );
-                $user_id = self::factory()->user->create( array( 'user_login' => 'user-a' ) );
+                $user_id = self::$user_a_id;
                 self::factory()->post->create_many( 3, array( 'post_author' => $user_id ) );
                 $this->go_to( '/author/user-a/page/2/' );
@@ -616 +631 @@
         // 'author/([^/]+)/?$' => 'index.php?author_name=$matches[1]',
         public function test_author() {
-                $user_id = self::factory()->user->create( array( 'user_login' => 'user-a' ) );
+                $user_id = self::$user_a_id;
                 self::factory()->post->create( array( 'post_author' => $user_id ) );
                 $this->go_to( '/author/user-a/' );
@@ -623 +638 @@
 
         public function test_author_with_no_posts() {
-                $user_id = self::factory()->user->create( array( 'user_login' => 'user-a' ) );
                 $this->go_to( '/author/user-a/' );
                 $this->assertQueryTrue( 'is_archive', 'is_author' );
@@ -1123 +1137 @@
          */
         public function test_is_author_with_nicename_that_begins_with_a_number_that_clashes_with_another_author_id() {
-                $u1 = self::factory()->user->create();
+                $u1 = self::$user_a_id;
 
                 $u2_name = $u1 . '_user';
@@ -1280 +1294 @@
 
                 // We need a non-post that shares an ID with a post assigned a template.
-                $user_id = self::factory()->user->create();
+                $user_id = self::$user_a_id;
                 if ( ! get_post( $user_id ) ) {
                         $post_id = self::factory()->post->create( array( 'post_type' => 'post' ) );
@@ -1353 +1367 @@
          */
         public function test_is_author_should_not_match_numeric_id_to_nickname_beginning_with_id() {
-                $u1 = self::factory()->user->create(
-                        array(
-                                'nickname'      => 'Foo',
-                                'user_nicename' => 'foo',
-                        )
-                );
+                $u1 = self::$user_a_id;
                 $u2 = self::factory()->user->create(
                         array(
@@ -1376 +1385 @@
          */
         public function test_is_author_should_not_match_numeric_id_to_user_nicename_beginning_with_id() {
-                $u1 = self::factory()->user->create(
-                        array(
-                                'nickname'      => 'Foo',
-                                'user_nicename' => 'foo',
-                        )
-                );
+                $u1 = self::$user_a_id;
                 $u2 = self::factory()->user->create(
                         array(