Changeset 60275

Timestamp:

06/03/2025 04:49:48 PM (15 months ago)

Author:

johnbillion

Message:

General: Various fixes to the correctness of code and documentation reported by PHPStan.

Props justlevine

See #63268

Location:

trunk/src

Files:

• wp-admin/includes/class-language-pack-upgrader.php (modified) (1 diff)
• wp-admin/includes/class-wp-automatic-updater.php (modified) (1 diff)
• wp-admin/includes/class-wp-filesystem-ftpsockets.php (modified) (2 diffs)
• wp-admin/includes/post.php (modified) (1 diff)
• wp-admin/includes/taxonomy.php (modified) (1 diff)
• wp-includes/block-template.php (modified) (1 diff)
• wp-includes/category-template.php (modified) (1 diff)
• wp-includes/class-wp-block-pattern-categories-registry.php (modified) (1 diff)
• wp-includes/class-wp-block-patterns-registry.php (modified) (1 diff)
• wp-includes/class-wp-block-styles-registry.php (modified) (1 diff)
• wp-includes/pluggable.php (modified) (1 diff)
• wp-includes/script-loader.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-language-pack-upgrader.php

@@ -384 +384 @@
                                 $theme = wp_get_theme( $update->slug );
                                 if ( $theme->exists() ) {
-                                        return $theme->Get( 'Name' );
+                                        return $theme->get( 'Name' );
                                 }
                                 break;

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -412 +412 @@
                                 $upgrader_item = $item->theme;
                                 $theme         = wp_get_theme( $upgrader_item );
-                                $item_name     = $theme->Get( 'Name' );
+                                $item_name     = $theme->get( 'Name' );
                                 // Add the current version so that it can be reported in the notification email.
                                 $item->current_version = $theme->get( 'Version' );

trunk/src/wp-admin/includes/class-wp-filesystem-ftpsockets.php

@@ -78 +78 @@
                 }
 
-                $this->ftp->setTimeout( FS_CONNECT_TIMEOUT );
+                $this->ftp->SetTimeout( FS_CONNECT_TIMEOUT );
 
                 if ( ! $this->ftp->SetServer( $this->options['hostname'], $this->options['port'] ) ) {
@@ -121 +121 @@
                 $this->ftp->SetType( FTP_BINARY );
                 $this->ftp->Passive( true );
-                $this->ftp->setTimeout( FS_TIMEOUT );
+                $this->ftp->SetTimeout( FS_TIMEOUT );
 
                 return true;

trunk/src/wp-admin/includes/post.php

@@ -2187 +2187 @@
  * @param int $post_id Optional. Post ID.
  */
-function redirect_post( $post_id = '' ) {
+function redirect_post( $post_id = 0 ) {
         if ( isset( $_POST['save'] ) || isset( $_POST['publish'] ) ) {
                 $status = get_post_status( $post_id );

trunk/src/wp-admin/includes/taxonomy.php

@@ -76 +76 @@
  * @return int[] Array of IDs of categories assigned to the given post.
  */
-function wp_create_categories( $categories, $post_id = '' ) {
+function wp_create_categories( $categories, $post_id = 0 ) {
         $cat_ids = array();
         foreach ( $categories as $category ) {

trunk/src/wp-includes/block-template.php

@@ -254 +254 @@
                         return '<h1>' . esc_html__( 'No matching template found' ) . '</h1>';
                 }
-                return;
+                return '';
         }
 

trunk/src/wp-includes/category-template.php

@@ -794 +794 @@
  */
 function default_topic_count_scale( $count ) {
-        return round( log10( $count + 1 ) * 100 );
+        return (int) round( log10( $count + 1 ) * 100 );
 }
 

trunk/src/wp-includes/class-wp-block-pattern-categories-registry.php

@@ -108 +108 @@
          *
          * @param string $category_name Pattern category name including namespace.
-         * @return array Registered pattern properties.
+         * @return array|null Registered pattern properties, or `null` if the pattern category is not registered.
          */
         public function get_registered( $category_name ) {

trunk/src/wp-includes/class-wp-block-patterns-registry.php

@@ -189 +189 @@
          *
          * @param string $pattern_name Block pattern name including namespace.
-         * @return array Registered pattern properties.
+         * @return array|null Registered pattern properties or `null` if the pattern is not registered.
          */
         public function get_registered( $pattern_name ) {

trunk/src/wp-includes/class-wp-block-styles-registry.php

@@ -141 +141 @@
          * @param string $block_name       Block type name including namespace.
          * @param string $block_style_name Block style name.
-         * @return array Registered block style properties.
+         * @return array|null Registered block style properties or `null` if the block style is not registered.
          */
         public function get_registered( $block_name, $block_style_name ) {

trunk/src/wp-includes/pluggable.php

@@ -447 +447 @@
                                                         break;
                                                 case 'cc':
-                                                        $phpmailer->addCc( $address, $recipient_name );
+                                                        $phpmailer->addCC( $address, $recipient_name );
                                                         break;
                                                 case 'bcc':
-                                                        $phpmailer->addBcc( $address, $recipient_name );
+                                                        $phpmailer->addBCC( $address, $recipient_name );
                                                         break;
                                                 case 'reply_to':

trunk/src/wp-includes/script-loader.php

@@ -397 +397 @@
                         array(
                                 '( function() {',
-                                '       var userId = ' . get_current_user_ID() . ';',
+                                '       var userId = ' . get_current_user_id() . ';',
                                 '       var storageKey = "WP_DATA_USER_" + userId;',
                                 '       wp.data',