Changeset 60285

Timestamp:

06/05/2025 02:00:28 PM (5 weeks ago)

Author:

desrosj

Message:

Media: Remove inline scripts targeting IE < 9.

In #24902, an inline script was introduced to wp_playlist_scripts(), wp_audio_shortcode(), and wp_video_shortcode() for HTML5 compatibility in browsers running IE 8 and earlier.

These browsers have long been unsupported by WordPress, and unsupported by Microsoft for 9 years or more. So this compatibility code is no longer necessary and can safely be removed.

Hit the road, Jack, and don't ya come back no more, no more, no more, no more!

Props aslamdoctor, mindctrl, nigelnelles, joedolson.
Fixes #63471.

Location:

trunk

Files:

• src/wp-includes/media.php (modified) (3 diffs)
• tests/phpunit/tests/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -2993 +2993 @@
     wp_enqueue_style( 'wp-mediaelement' );
     wp_enqueue_script( 'wp-playlist' );
-    ?>
-<!--[if lt IE 9]><script>document.createElement('<?php echo esc_js( $type ); ?>');</script><![endif]-->
-    <?php
     add_action( 'wp_footer', 'wp_underscore_playlist_templates', 0 );
     add_action( 'admin_footer', 'wp_underscore_playlist_templates', 0 );
@@ -3503 +3500 @@
     }
 
-    $html = '';
-
-    if ( 'mediaelement' === $library && 1 === $instance ) {
-        $html .= "<!--[if lt IE 9]><script>document.createElement('audio');</script><![endif]-->\n";
-    }
-
-    $html .= sprintf( '<audio %s controls="controls">', implode( ' ', $attr_strings ) );
-
+    $html    = sprintf( '<audio %s controls="controls">', implode( ' ', $attr_strings ) );
     $fileurl = '';
     $source  = '<source type="%s" src="%s" />';
@@ -3788 +3778 @@
     }
 
-    $html = '';
-
-    if ( 'mediaelement' === $library && 1 === $instance ) {
-        $html .= "<!--[if lt IE 9]><script>document.createElement('video');</script><![endif]-->\n";
-    }
-
-    $html .= sprintf( '<video %s controls="controls">', implode( ' ', $attr_strings ) );
-
+    $html    = sprintf( '<video %s controls="controls">', implode( ' ', $attr_strings ) );
     $fileurl = '';
     $source  = '<source type="%s" src="%s" />';

trunk/tests/phpunit/tests/media.php

@@ -1000 +1000 @@
 
         $expected = '<div style="width: ' . $width . 'px;" class="wp-video">' .
-            "<!--[if lt IE 9]><script>document.createElement('video');</script><![endif]-->\n" .
             '<video class="wp-video-shortcode" id="video-' . $post_id . '-1" width="' . $width . '" height="' . $h . '" preload="metadata" controls="controls">' .
             '<source type="video/mp4" src="http://domain.tld/wp-content/uploads/2013/12/xyz.mp4?_=1" />' .