Changeset 60301

Timestamp:

06/11/2025 05:40:44 PM (14 months ago)

Author:

johnbillion

Message:

REST API: Return a more appropriate HTTP 400 response code when attempting to create or update a non-existent setting.

This switches the response from a 200, which is not appropriate for invalid requests.

Props sheldorofazeroth, johnbillion

Fixes #41604

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-settings-controller.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php

@@ -147 +147 @@
 
                 $params = $request->get_params();
+
+                if ( empty( $params ) || ! empty( array_diff_key( $params, $options ) ) ) {
+                        $message = empty( $params )
+                                ? __( 'Request body cannot be empty.' )
+                                : __( 'Invalid parameter(s) provided.' );
+
+                        return new WP_Error(
+                                'rest_invalid_param',
+                                $message,
+                                array( 'status' => 400 )
+                        );
+                }
 
                 foreach ( $options as $name => $args ) {

trunk/tests/phpunit/tests/rest-api/rest-settings-controller.php

@@ -386 +386 @@
 
         /**
-         * @doesNotPerformAssertions
+         * Settings can't be created
          */
         public function test_create_item() {
-                // Controller does not implement create_item().
+                wp_set_current_user( self::$administrator );
+
+                $request = new WP_REST_Request( 'POST', '/wp/v2/settings' );
+                $request->set_param( 'new_setting', 'New value' );
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertSame( 400, $response->get_status() );
         }
 
         public function test_update_item() {
                 wp_set_current_user( self::$administrator );
+
                 $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
                 $request->set_param( 'title', 'The new title!' );
@@ -402 +409 @@
                 $this->assertSame( 'The new title!', $data['title'] );
                 $this->assertSame( get_option( 'blogname' ), $data['title'] );
+        }
+
+        public function test_update_nonexistent_item() {
+                wp_set_current_user( self::$administrator );
+
+                $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
+                $request->set_param( 'i_do_no_exist', 'New value' );
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertSame( 400, $response->get_status() );
+        }
+
+        public function test_update_partially_valid_items() {
+                wp_set_current_user( self::$administrator );
+
+                $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
+                $request->set_param( 'title', 'The new title!' );
+                $request->set_param( 'i_do_no_exist', 'New value' );
+                $response = rest_get_server()->dispatch( $request );
+
+                $this->assertSame( 400, $response->get_status() );
         }