Changeset 60301 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php

Timestamp:

06/11/2025 05:40:44 PM (8 months ago)

Author:

johnbillion

Message:

REST API: Return a more appropriate HTTP 400 response code when attempting to create or update a non-existent setting.

This switches the response from a 200, which is not appropriate for invalid requests.

Props sheldorofazeroth, johnbillion

Fixes #41604

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-settings-controller.php

@@ -147 +147 @@
 
         $params = $request->get_params();
+
+        if ( empty( $params ) || ! empty( array_diff_key( $params, $options ) ) ) {
+            $message = empty( $params )
+                ? __( 'Request body cannot be empty.' )
+                : __( 'Invalid parameter(s) provided.' );
+
+            return new WP_Error(
+                'rest_invalid_param',
+                $message,
+                array( 'status' => 400 )
+            );
+        }
 
         foreach ( $options as $name => $args ) {