Changeset 60304 for trunk

Timestamp:

06/12/2025 08:45:40 PM (15 months ago)

Author:

westonruter

Message:

Comments: Remove novalidate attribute from comments form by default.

Browser support for client-side validation is now reliable. Blocking the form submission when there is a missing/invalid field prevents the possibility of losing comment content when bfcache does not restore the previous page when going back.

To retain the novalidate attribute, the comment_form()'s args now accepts a novalidate key which will add the attribute when it is true. This can also be supplied by the comment_form_default_fields filter, for example:

add_filter( 'comment_form_defaults', function ( $args ) {
    $args['novalidate'] = true;
    return $args;
} );

Fixes #47595.
Props westonruter, joedolson, sabernhardt, afercia, SergeyBiryukov, guddu1315, pfefferle, oglekler, bugnumber9.

Location:

trunk

Files:

• src/wp-includes/comment-template.php (modified) (4 diffs)
• tests/phpunit/tests/comment/commentForm.php (modified) (1 diff)

trunk/src/wp-includes/comment-template.php

@@ -2447 +2447 @@
  * @since 4.9.6 Introduced the 'cookies' default comment field.
  * @since 5.5.0 Introduced the 'class_container' argument.
+ * @since 6.8.2 Introduced the 'novalidate' argument.
  *
  * @param array       $args {
@@ -2468 +2469 @@
  *     @type string $comment_notes_after  HTML element for a message displayed after the textarea field.
  *     @type string $action               The comment form element action attribute. Default '/wp-comments-post.php'.
+ *     @type bool   $novalidate           Whether the novalidate attribute is added to the comment form. Default false.
  *     @type string $id_form              The comment form element id attribute. Default 'commentform'.
  *     @type string $id_submit            The comment submit element id attribute. Default 'submit'.
@@ -2647 +2649 @@
                 'comment_notes_after'  => '',
                 'action'               => site_url( '/wp-comments-post.php' ),
+                'novalidate'           => false,
                 'id_form'              => 'commentform',
                 'id_submit'            => 'submit',
@@ -2730 +2733 @@
                                 esc_attr( $args['id_form'] ),
                                 esc_attr( $args['class_form'] ),
-                                ( $html5 ? ' novalidate' : '' )
+                                ( $args['novalidate'] ? ' novalidate' : '' )
                         );
 

trunk/tests/phpunit/tests/comment/commentForm.php

@@ -194 +194 @@
                 $this->assertStringContainsString( $post_hidden_field, $form );
         }
+
+        /**
+         * Tests novalidate attribute on the comment form.
+         *
+         * @ticket 47595
+         */
+        public function test_comment_form_and_novalidate_attribute() {
+                $post_id = self::$post_id;
+
+                // By default, the novalidate is not emitted.
+                $form = get_echo( 'comment_form', array( array(), $post_id ) );
+                $p    = new WP_HTML_Tag_Processor( $form );
+                $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+                $this->assertNull( $p->get_attribute( 'novalidate' ), 'Expected FORM to not have novalidate attribute by default.' );
+
+                // Opt in to the novalidate attribute by passing an arg to comment_form().
+                $form = get_echo( 'comment_form', array( array( 'novalidate' => true ), $post_id ) );
+                $p    = new WP_HTML_Tag_Processor( $form );
+                $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+                $this->assertTrue( $p->get_attribute( 'novalidate' ), 'Expected FORM to have the novalidate attribute.' );
+
+                // Opt in to the novalidate attribute via the comment_form_defaults filter.
+                add_filter(
+                        'comment_form_defaults',
+                        static function ( array $defaults ): array {
+                                $defaults['novalidate'] = true;
+                                return $defaults;
+                        }
+                );
+                $form = get_echo( 'comment_form', array( array(), $post_id ) );
+                $p    = new WP_HTML_Tag_Processor( $form );
+                $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+                $this->assertTrue( $p->get_attribute( 'novalidate' ), 'Expected FORM to have novalidate attribute.' );
+        }
 }