Changeset 60359 for trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

Timestamp:

06/27/2025 08:45:08 PM (14 months ago)

Author:

johnbillion

Message:

Posts, Post Types: Correct the schema for the id property of the global styles REST API endpoint.

This property is an integer as it corresponds to a post ID.

Props narenin, TimothyBlynJacobs, audrasjb, johnbillion, mikinc860, abcd95

Fixes #61911

File:

• trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php (modified) (6 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-controller.php

@@ -89 +89 @@
                 register_rest_route(
                         $this->namespace,
-                        '/' . $this->rest_base . '/(?P<id>[\/\w-]+)',
+                        '/' . $this->rest_base . '/(?P<id>[\/\d+]+)',
                         array(
                                 array(
@@ -97 +97 @@
                                         'args'                => array(
                                                 'id' => array(
-                                                        'description'       => __( 'The id of a template' ),
-                                                        'type'              => 'string',
-                                                        'sanitize_callback' => array( $this, '_sanitize_global_styles_callback' ),
+                                                        'description' => __( 'ID of global styles config.' ),
+                                                        'type'        => 'integer',
                                                 ),
                                         ),
@@ -116 +115 @@
 
         /**
-         * Sanitize the global styles ID or stylesheet to decode endpoint.
+         * Sanitize the global styles stylesheet to decode endpoint.
          * For example, `wp/v2/global-styles/twentytwentytwo%200.4.0`
          * would be decoded to `twentytwentytwo 0.4.0`.
@@ -122 +121 @@
          * @since 5.9.0
          *
-         * @param string $id_or_stylesheet Global styles ID or stylesheet.
-         * @return string Sanitized global styles ID or stylesheet.
-         */
-        public function _sanitize_global_styles_callback( $id_or_stylesheet ) {
-                return urldecode( $id_or_stylesheet );
+         * @param string $stylesheet Global styles stylesheet.
+         * @return string Sanitized global styles stylesheet.
+         */
+        public function _sanitize_global_styles_callback( $stylesheet ) {
+                return urldecode( $stylesheet );
         }
 
@@ -140 +139 @@
                 $error = new WP_Error(
                         'rest_global_styles_not_found',
-                        __( 'No global styles config exist with that id.' ),
+                        __( 'No global styles config exists with that ID.' ),
                         array( 'status' => 404 )
                 );
@@ -465 +464 @@
                                 'id'       => array(
                                         'description' => __( 'ID of global styles config.' ),
-                                        'type'        => 'string',
+                                        'type'        => 'integer',
                                         'context'     => array( 'embed', 'view', 'edit' ),
                                         'readonly'    => true,