Changeset 60412 for branches/6.8/tests/phpunit/tests/comment/commentForm.php

Timestamp:

07/05/2025 06:51:06 AM (7 months ago)

Author:

audrasjb

Message:

Comments: Remove novalidate attribute from comments form by default.

Browser support for client-side validation is now reliable. Blocking the form submission when there is a missing/invalid field prevents the possibility of losing comment content when bfcache does not restore the previous page when going back.

To retain the novalidate attribute, the comment_form()'s args now accepts a novalidate key which will add the attribute when it is true. This can also be supplied by the comment_form_default_fields filter, for example:

add_filter( 'comment_form_defaults', function ( $args ) {
    $args['novalidate'] = true;
    return $args;
} );

Reviewed by audrasjb.
Merges [60304] to the 6.8 branch.

Fixes #47595.
Props westonruter, joedolson, sabernhardt, afercia, SergeyBiryukov, guddu1315, pfefferle, oglekler, bugnumber9.

Location:

branches/6.8

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/comment/commentForm.php (modified) (1 diff)

branches/6.8/tests/phpunit/tests/comment/commentForm.php

@@ -194 +194 @@
         $this->assertStringContainsString( $post_hidden_field, $form );
     }
+
+    /**
+     * Tests novalidate attribute on the comment form.
+     *
+     * @ticket 47595
+     */
+    public function test_comment_form_and_novalidate_attribute() {
+        $post_id = self::$post_id;
+
+        // By default, the novalidate is not emitted.
+        $form = get_echo( 'comment_form', array( array(), $post_id ) );
+        $p    = new WP_HTML_Tag_Processor( $form );
+        $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+        $this->assertNull( $p->get_attribute( 'novalidate' ), 'Expected FORM to not have novalidate attribute by default.' );
+
+        // Opt in to the novalidate attribute by passing an arg to comment_form().
+        $form = get_echo( 'comment_form', array( array( 'novalidate' => true ), $post_id ) );
+        $p    = new WP_HTML_Tag_Processor( $form );
+        $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+        $this->assertTrue( $p->get_attribute( 'novalidate' ), 'Expected FORM to have the novalidate attribute.' );
+
+        // Opt in to the novalidate attribute via the comment_form_defaults filter.
+        add_filter(
+            'comment_form_defaults',
+            static function ( array $defaults ): array {
+                $defaults['novalidate'] = true;
+                return $defaults;
+            }
+        );
+        $form = get_echo( 'comment_form', array( array(), $post_id ) );
+        $p    = new WP_HTML_Tag_Processor( $form );
+        $this->assertTrue( $p->next_tag( array( 'tag_name' => 'FORM' ) ), 'Expected FORM tag.' );
+        $this->assertTrue( $p->get_attribute( 'novalidate' ), 'Expected FORM to have novalidate attribute.' );
+    }
 }