Changeset 60449

Timestamp:

07/12/2025 03:24:22 PM (4 months ago)

Author:

ocean90

Message:

Media: Disable upload button in browser's built-in file uploader if no file is selected.

Props karinchristen, krokodok, stefanvelthuys, hubersen, joedolson, mukesh27, rollybueno, ocean90.
Fixes #63561.

Location:

trunk/src/wp-admin

Files:

• css/forms.css (modified) (1 diff)
• css/themes.css (modified) (1 diff)
• includes/media.php (modified) (1 diff)
• media-new.php (modified) (1 diff)

trunk/src/wp-admin/css/forms.css

@@ -1593 +1593 @@
     }
 
-    .wp-upload-form input[type="submit"] {
-        margin-top: 10px;
-    }
-
     .wp-core-ui select,
     .wp-admin .form-table select {

trunk/src/wp-admin/css/themes.css

@@ -2014 +2014 @@
         display: block;
     }
+
+    :is(.upload-theme, .upload-plugin) .wp-upload-form input[type="submit"] {
+        margin-top: 10px;
+    }
 }
 

trunk/src/wp-admin/includes/media.php

@@ -2286 +2286 @@
             ?>
         </label>
-        <input type="file" name="async-upload" id="async-upload" />
+        <input type="file" name="async-upload" id="async-upload" required />
         <?php submit_button( _x( 'Upload', 'verb' ), 'primary', 'html-upload', false ); ?>
         <a href="#" onclick="try{top.tb_remove();}catch(e){}; return false;"><?php _e( 'Cancel' ); ?></a>

trunk/src/wp-admin/media-new.php

@@ -65 +65 @@
 require_once ABSPATH . 'wp-admin/admin-header.php';
 
-$form_class = 'media-upload-form type-form validate';
+$form_class = 'wp-upload-form media-upload-form type-form validate';
 
 if ( get_user_setting( 'uploader' ) || isset( $_GET['browser-uploader'] ) ) {