Changeset 60459

Timestamp:

07/15/2025 12:25:45 PM (9 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Remove extra check in wp_get_theme_data_template_parts().

The false === $metadata check would always be true, as a non-false value causes an early return right before. To clarify this behavior, the needless priming of $metadata = false was removed as well, as there is no scenario where it will not be immediately overwritten.

Follow-up to [56385].

Props justlevine.
See #63268.

File:

• trunk/src/wp-includes/global-styles-and-settings.php (modified) (2 diffs)

trunk/src/wp-includes/global-styles-and-settings.php

@@ -484 +484 @@
     $can_use_cached = ! wp_is_development_mode( 'theme' );
 
-    $metadata = false;
     if ( $can_use_cached ) {
         $metadata = wp_cache_get( $cache_key, $cache_group );
@@ -492 +491 @@
     }
 
-    if ( false === $metadata ) {
-        $metadata = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_template_parts();
-        if ( $can_use_cached ) {
-            wp_cache_set( $cache_key, $metadata, $cache_group );
-        }
+    $metadata = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_template_parts();
+    if ( $can_use_cached ) {
+        wp_cache_set( $cache_key, $metadata, $cache_group );
     }