WordPress.org
Get WordPress

Make WordPress Core

Changeset 60485


Ignore:
Timestamp:
07/18/2025 08:57:41 PM (13 months ago)
Author:
dmsnell
Message:

HTML API: Use assertEqualHTML() in wp_rel_ugc() tests.

In some tests, the expected output was updated to its pure HTML state, removing the wrapping call to wp_slash(). Instead, stripslashes() has been applied to the output of the code under function. This leaves more readable test failures.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9255
Discussed in https://core.trac.wordpress.org/ticket/63694

Props dmsnell, jonsurrell.
See #63694.

Location:
trunk/tests/phpunit/tests
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/comment.php

    r60251 r60485  
    169169
    170170                $comment = get_comment( $comment_id );
    171                 $this->assertSame( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, 'Comment: ' . $comment->comment_content );
     171                $this->assertEqualHTML( '<a href="http://example.localhost/something.html" rel="nofollow ugc">click</a>', $comment->comment_content, '<body>', 'Comment: ' . $comment->comment_content );
    172172        }
    173173

  • trunk/tests/phpunit/tests/formatting/wpRelUgc.php

    r55289 r60485  
    1313        public function test_add_ugc() {
    1414                $content  = '<p>This is some cool <a href="/">Code</a></p>';
    15                 $expected = '<p>This is some cool <a href=\"/\" rel=\"nofollow ugc\">Code</a></p>';
    16                 $this->assertSame( $expected, wp_rel_ugc( $content ) );
     15                $expected = '<p>This is some cool <a href="/" rel="nofollow ugc">Code</a></p>';
     16                $this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
    1717        }
    1818
    … …  
    2222        public function test_convert_ugc() {
    2323                $content  = '<p>This is some cool <a href="/" rel="weird">Code</a></p>';
    24                 $expected = '<p>This is some cool <a href=\"/\" rel=\"weird nofollow ugc\">Code</a></p>';
    25                 $this->assertSame( $expected, wp_rel_ugc( $content ) );
     24                $expected = '<p>This is some cool <a href="/" rel="weird nofollow ugc">Code</a></p>';
     25                $this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
    2626        }
    2727
    … …  
    3131         */
    3232        public function test_wp_rel_ugc( $input, $output, $expect_deprecation = false ) {
    33                 $this->assertSame( wp_slash( $output ), wp_rel_ugc( $input ) );
     33                $this->assertEqualHTML( $output, stripslashes( wp_rel_ugc( $input ) ) );
    3434        }
    3535
    … …  
    8282
    8383                $content  = '<p>This is some cool <a href="demo.com" download rel="hola">Code</a></p>';
    84                 $expected = '<p>This is some cool <a href=\"demo.com\" download rel=\"hola nofollow ugc\">Code</a></p>';
    85                 $this->assertSame( $expected, wp_rel_ugc( $content ) );
     84                $expected = '<p>This is some cool <a href="demo.com" download rel="hola nofollow ugc">Code</a></p>';
     85                $this->assertEqualHTML( $expected, stripslashes( wp_rel_ugc( $content ) ) );
    8686        }
    8787}
Note: See TracChangeset for help on using the changeset viewer.