Context Navigation

← Previous Change
Next Change →

schema.php

Timestamp:

07/22/2025 05:46:31 PM (12 months ago)

Author:

johnjamesjacoby

Message:

Multisite: Enforce consistent types on ID columns in multisite database tables, to better allow for foreign keys to more reliably be defined between them.

This change adjusts the install & upgrade routines so all of ID-based database columns in the multisite database tables are unsigned, bringing them up-to-speed with ID-based columns in single-site tables.

Additionally, the $wp_db_version number is bumped, and the pre_schema_upgrade() upgrade function is modified to accommodate & use that new version.

Follow-up to [10852].

Props spacedmonkey, johnjamesjacoby.

Fixes #40418.

File:

: 1 edited

trunk/src/wp-admin/includes/schema.php (modified) (6 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-admin/includes/schema.php

-              r60421
+              r60497
         // Multisite global tables.
         $ms_global_tables = "CREATE TABLE $wpdb->blogs (
         blog_id bigint(20) NOT NULL auto_increment,
         site_id bigint(20) NOT NULL default '0',
+        blog_id bigint(20) unsigned NOT NULL auto_increment,
+        site_id bigint(20) unsigned NOT NULL default '0',
         domain varchar(200) NOT NULL default '',
         path varchar(100) NOT NULL default '',
 …
 CREATE TABLE $wpdb->blogmeta (
         meta_id bigint(20) unsigned NOT NULL auto_increment,
         blog_id bigint(20) NOT NULL default '0',
+        blog_id bigint(20) unsigned NOT NULL default '0',
         meta_key varchar(255) default NULL,
         meta_value longtext,
 …
 ) $charset_collate;
 CREATE TABLE $wpdb->registration_log (
         ID bigint(20) NOT NULL auto_increment,
+        ID bigint(20) unsigned NOT NULL auto_increment,
         email varchar(255) NOT NULL default '',
         IP varchar(30) NOT NULL default '',
         blog_id bigint(20) NOT NULL default '0',
+        blog_id bigint(20) unsigned NOT NULL default '0',
         date_registered datetime NOT NULL default '0000-00-00 00:00:00',
         PRIMARY KEY  (ID),
 …
 ) $charset_collate;
 CREATE TABLE $wpdb->site (
         id bigint(20) NOT NULL auto_increment,
+        id bigint(20) unsigned NOT NULL auto_increment,
         domain varchar(200) NOT NULL default '',
         path varchar(100) NOT NULL default '',
 …
 ) $charset_collate;
 CREATE TABLE $wpdb->sitemeta (
         meta_id bigint(20) NOT NULL auto_increment,
         site_id bigint(20) NOT NULL default '0',
+        meta_id bigint(20) unsigned NOT NULL auto_increment,
+        site_id bigint(20) unsigned NOT NULL default '0',
         meta_key varchar(255) default NULL,
         meta_value longtext,
 …
 ) $charset_collate;
 CREATE TABLE $wpdb->signups (
         signup_id bigint(20) NOT NULL auto_increment,
+        signup_id bigint(20) unsigned NOT NULL auto_increment,
         domain varchar(200) NOT NULL default '',
         path varchar(100) NOT NULL default '',

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 60497 for trunk/src/wp-admin/includes/schema.php

Legend:

trunk/src/wp-admin/includes/schema.php

Download in other formats: