Changeset 60510 for trunk/src/wp-includes/post.php

Timestamp:

07/25/2025 08:35:12 AM (4 months ago)

Author:

johnbillion

Message:

Posts, Post Types: Don't unnecessarily recount terms when a post transitions between statuses that don't require them to be recounted.

This accounts for transitions where:

• Both the old and new statuses are not included in term counts.
• Both the old and new statuses are included in term counts.

This results in term counts only being recalculated when a post transitions between a counted and an uncounted status.

If the terms of the post are changed then the term recounting is still handled by wp_update_term_count() inside wp_set_object_terms().

Props hbhalodia, johnbillion, peterwilsoncc, mukesh27.

Fixes #63562

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -8176 +8176 @@
 
     // Update counts for the post's terms.
-    foreach ( (array) get_object_taxonomies( $post->post_type ) as $taxonomy ) {
-        $tt_ids = wp_get_object_terms( $post->ID, $taxonomy, array( 'fields' => 'tt_ids' ) );
-        wp_update_term_count( $tt_ids, $taxonomy );
+    foreach ( (array) get_object_taxonomies( $post->post_type, 'objects' ) as $taxonomy ) {
+        /** This filter is documented in wp-includes/taxonomy.php */
+        $counted_statuses = apply_filters( 'update_post_term_count_statuses', array( 'publish' ), $taxonomy );
+
+        /*
+         * Do not recalculate term count if both the old and new status are not included in term counts.
+         * This accounts for a transition such as draft -> pending.
+         */
+        if ( ! in_array( $old_status, $counted_statuses, true ) && ! in_array( $new_status, $counted_statuses, true ) ) {
+            continue;
+        }
+
+        /*
+         * Do not recalculate term count if both the old and new status are included in term counts.
+         *
+         * This accounts for transitioning between statuses which are both included in term counts. This can only occur
+         * if the `update_post_term_count_statuses` filter is in use to count more than just the 'publish' status.
+         */
+        if ( in_array( $old_status, $counted_statuses, true ) && in_array( $new_status, $counted_statuses, true ) ) {
+            continue;
+        }
+
+        $tt_ids = wp_get_object_terms( $post->ID, $taxonomy->name, array( 'fields' => 'tt_ids' ) );
+        wp_update_term_count( $tt_ids, $taxonomy->name );
     }
 }