Changeset 6064 for trunk/wp-includes/functions.php

Timestamp:

09/08/2007 02:27:24 PM (18 years ago)

Author:

markjaquith

Message:

Only urlencode previously existing values in add_query_arg() (more backwards compatible). fixes #4935. see #4084. see #4878

File:

• trunk/wp-includes/functions.php (modified) (3 diffs)

trunk/wp-includes/functions.php

@@ -582 +582 @@
 }
 
+function build_query($data) {
+    return _http_build_query($data, NULL, '&', '', false);
+}
+
 /*
 add_query_arg: Returns a modified querystring by adding
@@ -636 +640 @@
 
     wp_parse_str($query, $qs);
+    $qs = urlencode_deep($qs); // this re-URL-encodes things that were already in the query string
     if ( is_array(func_get_arg(0)) ) {
         $kayvees = func_get_arg(0);
@@ -648 +653 @@
     }
 
-    if ( ini_get('arg_separator.output') === '&')
-        $ret = http_build_query($qs, '', '&');
-    else
-        $ret = _http_build_query($qs, NULL, '&');
+    $ret = build_query($qs);
     $ret = trim($ret, '?');
     $ret = preg_replace('#=(&|$)#', '$1', $ret);