Changeset 60643 for trunk/src/wp-admin/includes/dashboard.php

Timestamp:

08/17/2025 04:57:30 PM (3 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Move count() usage in wp_dashboard_recent_comments().

While the rule to discourage using functions like count() in a loop condition is a recommendation/best practice rule from the WordPress-Extra ruleset and does not directly apply to WordPress core, this is intended as a minor readability and code clarity improvement.

Follow-up to [10090], [17556], [20609], [26144].

Props krunal265, johnbillion, audrasjb, dhruvang21, SergeyBiryukov.
Fixes #56499.

File:

• trunk/src/wp-admin/includes/dashboard.php (modified) (3 diffs)

trunk/src/wp-admin/includes/dashboard.php

@@ -1075 +1075 @@
     }
 
-    while ( count( $comments ) < $total_items && $possible = get_comments( $comments_query ) ) {
-        if ( ! is_array( $possible ) ) {
+    do {
+        $possible = get_comments( $comments_query );
+
+        if ( empty( $possible ) || ! is_array( $possible ) ) {
             break;
         }
@@ -1089 +1091 @@
             }
 
-            $comments[] = $comment;
-
-            if ( count( $comments ) === $total_items ) {
+            $comments[]     = $comment;
+            $comments_count = count( $comments );
+
+            if ( $comments_count === $total_items ) {
                 break 2;
             }
@@ -1098 +1101 @@
         $comments_query['offset'] += $comments_query['number'];
         $comments_query['number']  = $total_items * 10;
-    }
+    } while ( $comments_count < $total_items );
 
     if ( $comments ) {