Context Navigation

← Previous Change
Next Change →

class-wp-term-query.php

Timestamp:

08/26/2025 05:24:06 PM (11 months ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Check the result of get_term() in WP_Term_Query::get_terms().

get_term() can return WP_Error or null on failure, so the result should be verified as a WP_Term instance before accessing the count property.

This commit prevents a PHP warning if get_term() returns null for a child term:

Warning: Attempt to read property "count" on null

Follow-up to [27458], [37572].

Props josephscott, coleatkinson1, kebbet, jakariaistauk, sabernhardt, westonruter, SergeyBiryukov.
Fixes #63877.

File:

: 1 edited

trunk/src/wp-includes/class-wp-term-query.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/src/wp-includes/class-wp-term-query.php

-              r59325
+              r60661
                                                 foreach ( $children as $child_id ) {
                                                         $child = get_term( $child_id, $term->taxonomy );
+                                                        if ( $child->count ) {
+                                                        if ( $child instanceof WP_Term && $child->count ) {
                                                                 continue 2;
+                                                        }

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 60661 for trunk/src/wp-includes/class-wp-term-query.php

Legend:

trunk/src/wp-includes/class-wp-term-query.php

Download in other formats: