WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
08/29/2025 05:16:50 PM (2 months ago)
Author:
jonsurrell
Message:

Script Loader: Revert sourceURL addition.

It was discovered that these changes cause some issues in the customizer when SCRIPT_DEBUG is false.

Reverts [60685] and [60686].

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9671

Props jonsurrell, wildworks, tyxla.
See #63887.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/dependencies/styles.php

    r60686 r60690  
    151151        $expected .= "<style id='handle-inline-css' type='text/css'>\n";
    152152        $expected .= "$style\n";
    153         $expected .= "/*# sourceURL=handle-inline-css */\n";
    154153        $expected .= "</style>\n";
    155154
    … …  
    181180        $expected .= "<style id='handle-inline-css' type='text/css'>\n";
    182181        $expected .= "$style\n";
    183         $expected .= "/*# sourceURL=handle-inline-css */\n";
    184182        $expected .= "</style>\n";
    185183
    … …  
    277275        $expected .= "$style1\n";
    278276        $expected .= "$style2\n";
    279         $expected .= "/*# sourceURL=handle-inline-css */\n";
    280277        $expected .= "</style>\n";
    281278
    … …  
    296293    public function test_plugin_doing_inline_styles_wrong() {
    297294
    298         $style  = ".thing {\n";
     295        $style  = "<style id='handle-inline-css' type='text/css'>\n";
     296        $style .= ".thing {\n";
    299297        $style .= "\tbackground: red;\n";
    300         $style .= '}';
     298        $style .= "}\n";
     299        $style .= '</style>';
    301300
    302301        $expected  = "<link rel='stylesheet' id='handle-css' href='http://example.com?ver=1' type='text/css' media='all' />\n";
    303         $expected .= "<style id='handle-inline-css' type='text/css'>\n";
    304302        $expected .= "$style\n";
    305         $expected .= "/*# sourceURL=handle-inline-css */\n";
    306         $expected .= "</style>\n";
    307303
    308304        wp_enqueue_style( 'handle', 'http://example.com', array(), 1 );
    309305
    310         wp_add_inline_style( 'handle', "<style>{$style}</style>" );
     306        wp_add_inline_style( 'handle', $style );
    311307
    312308        $this->assertSame( $expected, get_echo( 'wp_print_styles' ) );
    … …  
    337333<style id='handle-inline-css' type='text/css'>
    338334a { color: blue; }
    339 /*# sourceURL=handle-inline-css */
    340335</style>
    341336<![endif]-->
    … …  
    369364        $expected .= "<style id='handle-three-inline-css' type='text/css'>\n";
    370365        $expected .= "$style\n";
    371         $expected .= "/*# sourceURL=handle-three-inline-css */\n";
    372366        $expected .= "</style>\n";
    373367
    … …  
    639633        $this->assertSame( $GLOBALS['wp_styles']->registered['test-handle']->src, $url );
    640634    }
    641 
    642     /**
    643      * @ticket 63887
    644      */
    645     public function test_source_url_encoding() {
    646         $handle = '# test/</style> #';
    647         wp_enqueue_style( $handle, '/example.css', array(), '0.0' );
    648         wp_add_inline_style( $handle, 'custom-el { content: "ok"; }' );
    649 
    650         $expected = <<<HTML
    651 <link rel='stylesheet' href="/example.css?ver=0.0" id="# test/</style> #-css" media="all" type="text/css">
    652 <style id="# test/</style> #-inline-css" type="text/css">
    653 custom-el { content: "ok"; }
    654 /*# sourceURL=%23%20test%2F%3C%2Fstyle%3E%20%23-inline-css */
    655 </style>
    656 
    657 HTML;
    658 
    659         $this->assertEqualHTML( $expected, get_echo( 'wp_print_styles' ) );
    660     }
    661635}
Note: See TracChangeset for help on using the changeset viewer.