Changeset 60701

Timestamp:

09/02/2025 04:48:32 PM (11 months ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Check the result of creating a draft in get_default_post_to_edit().

As wp_insert_post() can return an error for various reasons, this commit ensures that this scenario is properly handled and an error message is displayed.

Follow-up to [12987].

Props rishabhwp, tfrommen, SirLouen, siliconforks, SergeyBiryukov.
Fixes #37441.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -769 +769 @@
                                 'post_status' => 'auto-draft',
                         ),
-                        false,
+                        true,
                         false
                 );
-                $post    = get_post( $post_id );
+
+                if ( is_wp_error( $post_id ) ) {
+                        wp_die( $post_id->get_error_message() );
+                }
+
+                $post = get_post( $post_id );
+
                 if ( current_theme_supports( 'post-formats' ) && post_type_supports( $post->post_type, 'post-formats' ) && get_option( 'default_post_format' ) ) {
                         set_post_format( $post, get_option( 'default_post_format' ) );
                 }
+
                 wp_after_insert_post( $post, false, null );
 

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -533 +533 @@
 
                 $this->assertSame( 1, $action->get_call_count() );
+        }
+
+        /**
+         * Tests that get_default_post_to_edit() calls wp_die() if wp_insert_post() returns a WP_Error.
+         *
+         * @ticket 37441
+         *
+         * @covers ::get_default_post_to_edit
+         */
+        public function test_get_default_post_to_edit_with_wp_insert_post_error() {
+                add_filter( 'wp_insert_post_empty_content', '__return_true' );
+
+                $this->expectException( 'WPDieException' );
+                get_default_post_to_edit( 'post', true );
         }