Changeset 60707 for trunk/tests/phpunit/includes/build-visual-html-tree.php

Timestamp:

09/04/2025 02:48:51 PM (2 months ago)

Author:

jonsurrell

Message:

Build/Test Tools: Ensure assertEqualHTML fallback render can be reached.

assertEqualHTML catches Exceptions and attempts to re-parse the HTML with the Dom\HtmlDocument class. Ensure that the fallback render is reachable by throwing Exception instead of Error in the tree builder function.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/9273.

Follow-up to [60295].

Props jonsurrell, bernhard-reiter, dmsnell.
Fixes #63527.

File:

• trunk/tests/phpunit/includes/build-visual-html-tree.php (modified) (4 diffs)

trunk/tests/phpunit/includes/build-visual-html-tree.php

@@ -41 +41 @@
  * @since 6.9.0
  *
- * @throws WP_HTML_Unsupported_Exception|Error If the markup could not be parsed.
+ * @throws WP_HTML_Unsupported_Exception|Exception If the markup could not be parsed.
  *
  * @param string      $html             Given test HTML.
@@ -52 +52 @@
         : WP_HTML_Processor::create_full_parser( $html );
     if ( null === $processor ) {
-        throw new Error( 'Could not create a parser.' );
+        throw new Exception( 'Could not create a parser.' );
     }
     $tree_indent = '  ';
@@ -281 +281 @@
                 // phpcs:ignore WordPress.PHP.DevelopmentFunctions.error_log_var_export
                 $serialized_token_type = var_export( $processor->get_token_type(), true );
-                throw new Error( "Unhandled token type for tree construction: {$serialized_token_type}" );
+                throw new Exception( "Unhandled token type for tree construction: {$serialized_token_type}" );
         }
     }
@@ -290 +290 @@
 
     if ( null !== $processor->get_last_error() ) {
-        throw new Error( "Parser error: {$processor->get_last_error()}" );
+        throw new Exception( "Parser error: {$processor->get_last_error()}" );
     }
 
     if ( $processor->paused_at_incomplete_token() ) {
-        throw new Error( 'Paused at incomplete token.' );
+        throw new Exception( 'Paused at incomplete token.' );
     }