Changeset 60729 for trunk/tests/phpunit/tests/admin/plugin-dependencies/base.php

Timestamp:

09/11/2025 02:45:56 PM (5 months ago)

Author:

swissspidy

Message:

Code Modernization: Address reflection no-op function deprecations in PHP 8.5.

Reflection*::setAccessible() methods are no-ops since PHP 8.1. This commit adds conditional checks to only call these functions on older PHP versions.

Reference: ​PHP RFC: Deprecations for PHP 8.5: Deprecate `Reflection*::setAccessible()`.

Props rishabhwp, swissspidy.
Fixes #63956.
See #63061.

File:

• trunk/tests/phpunit/tests/admin/plugin-dependencies/base.php (modified) (3 diffs)

trunk/tests/phpunit/tests/admin/plugin-dependencies/base.php

@@ -83 +83 @@
         }
 
-        self::$reflected_members[ $property ]->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $property ]->setAccessible( true );
+        }
         self::$reflected_members[ $property ]->setValue( self::$instance, $value );
-        self::$reflected_members[ $property ]->setAccessible( false );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $property ]->setAccessible( false );
+        }
     }
 
@@ -99 +103 @@
         }
 
-        self::$reflected_members[ $property ]->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $property ]->setAccessible( true );
+        }
         $value = self::$reflected_members[ $property ]->getValue( self::$instance );
-        self::$reflected_members[ $property ]->setAccessible( false );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $property ]->setAccessible( false );
+        }
 
         return $value;
@@ -119 +127 @@
         }
 
-        self::$reflected_members[ $method ]->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $method ]->setAccessible( true );
+        }
         $value = self::$reflected_members[ $method ]->invokeArgs( self::$instance, $args );
-        self::$reflected_members[ $method ]->setAccessible( false );
+        if ( PHP_VERSION_ID < 80100 ) {
+            self::$reflected_members[ $method ]->setAccessible( false );
+        }
 
         return $value;