Changeset 60729 for trunk/tests/phpunit/tests/admin/wpUpgrader.php

Timestamp:

09/11/2025 02:45:56 PM (4 months ago)

Author:

swissspidy

Message:

Code Modernization: Address reflection no-op function deprecations in PHP 8.5.

Reflection*::setAccessible() methods are no-ops since PHP 8.1. This commit adds conditional checks to only call these functions on older PHP versions.

Reference: ​PHP RFC: Deprecations for PHP 8.5: Deprecate `Reflection*::setAccessible()`.

Props rishabhwp, swissspidy.
Fixes #63956.
See #63061.

File:

• trunk/tests/phpunit/tests/admin/wpUpgrader.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/wpUpgrader.php

@@ -171 +171 @@
     public function test_flatten_dirlist_should_flatten_the_provided_directory_list( $expected, $nested_files, $path = '' ) {
         $flatten_dirlist = new ReflectionMethod( self::$instance, 'flatten_dirlist' );
-        $flatten_dirlist->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $flatten_dirlist->setAccessible( true );
+        }
         $actual = $flatten_dirlist->invoke( self::$instance, $nested_files, $path );
-        $flatten_dirlist->setAccessible( false );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $flatten_dirlist->setAccessible( false );
+        }
 
         $this->assertSameSetsWithIndex( $expected, $actual );