Changeset 60729 for trunk/tests/phpunit/tests/error-protection/wpRecoveryModeCookieService.php

Timestamp:

09/11/2025 02:45:56 PM (6 months ago)

Author:

swissspidy

Message:

Code Modernization: Address reflection no-op function deprecations in PHP 8.5.

Reflection*::setAccessible() methods are no-ops since PHP 8.1. This commit adds conditional checks to only call these functions on older PHP versions.

Reference: ​PHP RFC: Deprecations for PHP 8.5: Deprecate `Reflection*::setAccessible()`.

Props rishabhwp, swissspidy.
Fixes #63956.
See #63061.

File:

• trunk/tests/phpunit/tests/error-protection/wpRecoveryModeCookieService.php (modified) (4 diffs)

trunk/tests/phpunit/tests/error-protection/wpRecoveryModeCookieService.php

@@ -36 +36 @@
         $service    = new WP_Recovery_Mode_Cookie_Service();
         $reflection = new ReflectionMethod( $service, 'recovery_mode_hash' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $to_sign = sprintf( 'recovery_mode|%s|%s', time() - WEEK_IN_SECONDS - 30, wp_generate_password( 20, false ) );
@@ -55 +57 @@
         $service    = new WP_Recovery_Mode_Cookie_Service();
         $reflection = new ReflectionMethod( $service, 'generate_cookie' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $cookie  = $reflection->invoke( $service );
@@ -73 +77 @@
         $service    = new WP_Recovery_Mode_Cookie_Service();
         $reflection = new ReflectionMethod( $service, 'recovery_mode_hash' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $to_sign = sprintf( 'recovery_mode|%s|%s', 'month', wp_generate_password( 20, false ) );
@@ -93 +99 @@
         $service    = new WP_Recovery_Mode_Cookie_Service();
         $reflection = new ReflectionMethod( $service, 'generate_cookie' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $this->assertTrue( $service->validate_cookie( $reflection->invoke( $service ) ) );