Changeset 60729 for trunk/tests/phpunit/tests/query/cacheResults.php

Timestamp:

09/11/2025 02:45:56 PM (5 months ago)

Author:

swissspidy

Message:

Code Modernization: Address reflection no-op function deprecations in PHP 8.5.

Reflection*::setAccessible() methods are no-ops since PHP 8.1. This commit adds conditional checks to only call these functions on older PHP versions.

Reference: ​PHP RFC: Deprecations for PHP 8.5: Deprecate `Reflection*::setAccessible()`.

Props rishabhwp, swissspidy.
Fixes #63956.
See #63061.

File:

• trunk/tests/phpunit/tests/query/cacheResults.php (modified) (7 diffs)

trunk/tests/phpunit/tests/query/cacheResults.php

@@ -103 +103 @@
 
         $reflection = new ReflectionMethod( $query1, 'generate_cache_key' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $cache_key_1 = $reflection->invoke( $query1, $query_vars, $request );
@@ -159 +161 @@
 
         $reflection = new ReflectionMethod( $query1, 'generate_cache_key' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $cache_key_1 = $reflection->invoke( $query1, $query_vars, $request );
@@ -192 +196 @@
 
         $reflection = new ReflectionMethod( $query1, 'generate_cache_key' );
-        $reflection->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection->setAccessible( true );
+        }
 
         $cache_key_1 = $reflection->invoke( $query1, $query_vars, $request1 );
@@ -228 +234 @@
 
         $reflection_q1 = new ReflectionProperty( $query1, 'query_cache_key' );
-        $reflection_q1->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q1->setAccessible( true );
+        }
 
         $reflection_q2 = new ReflectionProperty( $query2, 'query_cache_key' );
-        $reflection_q2->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q2->setAccessible( true );
+        }
 
         $this->assertNotSame( $request1, $request2, 'Queries should not match' );
@@ -289 +299 @@
 
         $reflection_q1 = new ReflectionProperty( $query1, 'query_cache_key' );
-        $reflection_q1->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q1->setAccessible( true );
+        }
 
         $reflection_q2 = new ReflectionProperty( $query2, 'query_cache_key' );
-        $reflection_q2->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q2->setAccessible( true );
+        }
 
         $this->assertNotSame( $request1, $request2, 'Queries should not match' );
@@ -346 +360 @@
 
         $reflection_q1 = new ReflectionProperty( $query1, 'query_cache_key' );
-        $reflection_q1->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q1->setAccessible( true );
+        }
 
         $reflection_q2 = new ReflectionProperty( $query2, 'query_cache_key' );
-        $reflection_q2->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q2->setAccessible( true );
+        }
 
         $this->assertNotSame( $request1, $request2, 'Queries should not match' );
@@ -386 +404 @@
 
         $reflection_q1 = new ReflectionProperty( $query1, 'query_cache_key' );
-        $reflection_q1->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q1->setAccessible( true );
+        }
 
         $reflection_q2 = new ReflectionProperty( $query2, 'query_cache_key' );
-        $reflection_q2->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $reflection_q2->setAccessible( true );
+        }
 
         $this->assertSame( $request1, $request2, 'Queries should match' );