Changeset 60729 for trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

Timestamp:

09/11/2025 02:45:56 PM (5 months ago)

Author:

swissspidy

Message:

Code Modernization: Address reflection no-op function deprecations in PHP 8.5.

Reflection*::setAccessible() methods are no-ops since PHP 8.1. This commit adds conditional checks to only call these functions on older PHP versions.

Reference: ​PHP RFC: Deprecations for PHP 8.5: Deprecate `Reflection*::setAccessible()`.

Props rishabhwp, swissspidy.
Fixes #63956.
See #63061.

File:

• trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php (modified) (4 diffs)

trunk/tests/phpunit/tests/theme/wpThemeJsonResolver.php

@@ -78 +78 @@
 
         static::$property_blocks_cache = new ReflectionProperty( WP_Theme_JSON_Resolver::class, 'blocks_cache' );
-        static::$property_blocks_cache->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            static::$property_blocks_cache->setAccessible( true );
+        }
         static::$property_blocks_cache_orig_value = static::$property_blocks_cache->getValue();
 
         static::$property_core = new ReflectionProperty( WP_Theme_JSON_Resolver::class, 'core' );
-        static::$property_core->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            static::$property_core->setAccessible( true );
+        }
         static::$property_core_orig_value = static::$property_core->getValue();
     }
@@ -307 +311 @@
     public function test_has_same_registered_blocks_when_all_blocks_not_cached( $origin, array $cache = array() ) {
         $has_same_registered_blocks = new ReflectionMethod( WP_Theme_JSON_Resolver::class, 'has_same_registered_blocks' );
-        $has_same_registered_blocks->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $has_same_registered_blocks->setAccessible( true );
+        }
         $expected_cache = $this->get_registered_block_names();
 
@@ -381 +387 @@
     public function test_has_same_registered_blocks_when_all_blocks_are_cached( $origin ) {
         $has_same_registered_blocks = new ReflectionMethod( WP_Theme_JSON_Resolver::class, 'has_same_registered_blocks' );
-        $has_same_registered_blocks->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $has_same_registered_blocks->setAccessible( true );
+        }
         $expected_cache = $this->get_registered_block_names();
 
@@ -837 +845 @@
         // Force-unset $i18n_schema property to "unload" translation schema.
         $property = new ReflectionProperty( $theme_json_resolver, 'i18n_schema' );
-        $property->setAccessible( true );
+        if ( PHP_VERSION_ID < 80100 ) {
+            $property->setAccessible( true );
+        }
         $property->setValue( null, null );