Changeset 60733

Timestamp:

09/12/2025 09:16:41 PM (11 months ago)

Author:

westonruter

Message:

Posts, Post Types: Fix placement of WP_Error check in get_adjacent_post().

Props kitchin, mindctrl, westonruter, SirLouen, SergeyBiryukov, pmbaldha.
Fixes #63920.

Location:

trunk

Files:

• src/wp-includes/link-template.php (modified) (1 diff)
• tests/phpunit/tests/link/getAdjacentPost.php (modified) (1 diff)

trunk/src/wp-includes/link-template.php

@@ -1889 +1889 @@
                         }
                         $term_array = wp_get_object_terms( $post->ID, $taxonomy, array( 'fields' => 'ids' ) );
+                        if ( is_wp_error( $term_array ) ) {
+                                return '';
+                        }
 
                         // Remove any exclusions from the term array to include.
                         $term_array = array_diff( $term_array, (array) $excluded_terms );
-                        $term_array = array_map( 'intval', $term_array );
-
-                        if ( ! $term_array || is_wp_error( $term_array ) ) {
+
+                        if ( ! $term_array ) {
                                 return '';
                         }
+
+                        $term_array = array_map( 'intval', $term_array );
 
                         $where .= ' AND tt.term_id IN (' . implode( ',', $term_array ) . ')';

trunk/tests/phpunit/tests/link/getAdjacentPost.php

@@ -353 +353 @@
 
         /**
+         * @ticket 63920
+         */
+        public function test_get_adjacent_post_returns_empty_string_when_wp_get_object_terms_returns_wp_error() {
+                register_taxonomy( 'wptests_error_tax', 'post' );
+
+                $term1_id = self::factory()->term->create(
+                        array(
+                                'taxonomy' => 'wptests_error_tax',
+                        )
+                );
+
+                $post1_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'First',
+                                'post_date'  => '2025-09-01 12:00:00',
+                        )
+                );
+
+                $post2_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'Second',
+                                'post_date'  => '2025-09-02 12:00:00',
+                        )
+                );
+
+                wp_set_post_terms( $post1_id, array( $term1_id ), 'wptests_error_tax' );
+                wp_set_post_terms( $post2_id, array( $term1_id ), 'wptests_error_tax' );
+
+                $this->go_to( get_permalink( $post2_id ) );
+
+                add_filter(
+                        'wp_get_object_terms',
+                        static function () {
+                                return new WP_Error( 'test_error', 'Test error from wp_get_object_terms' );
+                        }
+                );
+                $result = get_adjacent_post( true, '', true, 'wptests_error_tax' );
+                $this->assertSame( '', $result );
+        }
+
+        /**
+         * @ticket 63920
+         */
+        public function test_get_adjacent_post_empty_term_array_after_exclusions() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $term1_id = self::factory()->term->create(
+                        array(
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+
+                $post1_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'First',
+                                'post_date'  => '2025-01-01 12:00:00',
+                        )
+                );
+
+                $post2_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'Second',
+                                'post_date'  => '2025-02-01 12:00:00',
+                        )
+                );
+
+                wp_set_post_terms( $post1_id, array( $term1_id ), 'wptests_tax' );
+                wp_set_post_terms( $post2_id, array( $term1_id ), 'wptests_tax' );
+
+                $this->go_to( get_permalink( $post2_id ) );
+                $result = get_adjacent_post( true, array( $term1_id ), true, 'wptests_tax' );
+                $this->assertSame( '', $result );
+        }
+
+        /**
+         * @ticket 63920
+         */
+        public function test_get_adjacent_post_term_array_processing_order() {
+                register_taxonomy( 'wptests_tax', 'post' );
+
+                $term1_id = self::factory()->term->create(
+                        array(
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+                $term2_id = self::factory()->term->create(
+                        array(
+                                'taxonomy' => 'wptests_tax',
+                        )
+                );
+
+                $post1_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'First',
+                                'post_date'  => '2025-01-01 12:00:00',
+                        )
+                );
+
+                $post2_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'Second',
+                                'post_date'  => '2025-02-01 12:00:00',
+                        )
+                );
+
+                $post3_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'Third',
+                                'post_date'  => '2025-03-01 12:00:00',
+                        )
+                );
+
+                // All posts have term1. post_two has term1 and term2.
+                wp_set_post_terms( $post1_id, array( $term1_id ), 'wptests_tax' );
+                wp_set_post_terms( $post2_id, array( $term1_id, $term2_id ), 'wptests_tax' );
+                wp_set_post_terms( $post3_id, array( $term1_id ), 'wptests_tax' );
+
+                // Set the current post to post_two.
+                $this->go_to( get_permalink( $post2_id ) );
+
+                // When we exclude term2, we should still get adjacent posts that share term1.
+                $result = get_adjacent_post( true, array( $term2_id ), true, 'wptests_tax' );
+
+                // Should find post_one (previous post that shares term1).
+                $this->assertInstanceOf( WP_Post::class, $result );
+                $this->assertEquals( $post1_id, $result->ID );
+
+                // Test next post.
+                $result = get_adjacent_post( true, array( $term2_id ), false, 'wptests_tax' );
+
+                // Should find post_three (next post that shares term1).
+                $this->assertInstanceOf( WP_Post::class, $result );
+                $this->assertEquals( $post3_id, $result->ID );
+        }
+
+        /**
+         * @ticket 63920
+         */
+        public function test_get_adjacent_post_invalid_taxonomy() {
+                self::factory()->post->create(
+                        array(
+                                'post_title' => 'First',
+                                'post_date'  => '2025-01-01 12:00:00',
+                        )
+                );
+
+                $post2_id = self::factory()->post->create(
+                        array(
+                                'post_title' => 'Second',
+                                'post_date'  => '2025-02-01 12:00:00',
+                        )
+                );
+
+                $this->go_to( get_permalink( $post2_id ) );
+                $result = get_adjacent_post( true, '', true, 'invalid_taxonomy' );
+                $this->assertNull( $result );
+        }
+
+        /**
          * @ticket 41131
          */