Changeset 60736

Timestamp:

09/13/2025 12:14:39 PM (2 months ago)

Author:

johnbillion

Message:

Media: Temporarily disable failing tests when Imagick 7 is in use, pending further investigation.

The updated PHP 8.4 and 8.3 containers are running Imagick 7 which is producing some test failures for AVIFs and PNGs with 1-bit transparency. This requires further investigation, possibly accompanied by more comprehensive testing across Imagick versions, so these tests are disabled for now.

Additional missing assertions have also been added which ensure an unexpected WP_Error instance correctly fails the test and is not passed to an image processing function.

Props johnbillion, siliconforks, desrosj, jorbin.

See #63932

Location:

trunk/tests/phpunit/tests

Files:

• image/editorImagick.php (modified) (3 diffs)
• image/resize.php (modified) (12 diffs)
• media.php (modified) (3 diffs)

trunk/tests/phpunit/tests/image/editorImagick.php

@@ -706 +706 @@
      *
      * @ticket 62285
+     *
+     * Temporarily disabled until we can figure out why it fails on the Trixie based PHP container.
+     * See https://core.trac.wordpress.org/ticket/63932.
+     * @requires PHP < 8.3
      */
     public function test_image_max_bit_depth() {
@@ -780 +784 @@
     public function test_resizes_are_small_for_16bit_images( $file ) {
 
+        // Temporarily disabled. See https://core.trac.wordpress.org/ticket/63932.
+        if ( DIR_TESTDATA . '/images/png-tests/test8.png' === $file ) {
+            $version = Imagick::getVersion();
+            if ( $version['versionNumber'] >= 0x700 ) {
+                $this->markTestSkipped( 'ImageMagick 7 is unable to optimize grayscale images with 1-bit transparency.' );
+            }
+        }
+
         $temp_file = DIR_TESTDATA . '/images/test-temp.png';
 
@@ -835 +847 @@
      */
     public function test_png_color_type_is_preserved_after_resize( $file_path, $expected_color_type ) {
+
+        // Temporarily disabled. See https://core.trac.wordpress.org/ticket/63932.
+        if ( DIR_TESTDATA . '/images/png-tests/test8.png' === $file_path ) {
+            $version = Imagick::getVersion();
+            if ( $version['versionNumber'] >= 0x700 ) {
+                $this->markTestSkipped( 'ImageMagick 7 is unable to optimize grayscale images with 1-bit transparency.' );
+            }
+        }
 
         $temp_file = DIR_TESTDATA . '/images/test-temp.png';

trunk/tests/phpunit/tests/image/resize.php

@@ -24 +24 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/test-image.jpg', 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -79 +81 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -93 +97 @@
      *
      * @ticket 51228
+     *
+     * Temporarily disabled until we can figure out why it fails on the Trixie based PHP container.
+     * See https://core.trac.wordpress.org/ticket/63932.
+     * @requires PHP < 8.3
      */
     public function test_resize_avif() {
@@ -105 +113 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -131 +141 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -152 +164 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 128, 96 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -165 +179 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 128, 0 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -178 +194 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 0, 96 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -191 +209 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 150, 150, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -204 +224 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 150, 100, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -217 +239 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 50, 150, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -241 +265 @@
     /**
      * Function to help out the tests
+     *
+     * @return string|WP_Error The path to the resized image file or a WP_Error on failure.
      */
     protected function resize_helper( $file, $width, $height, $crop = false ) {

trunk/tests/phpunit/tests/media.php

@@ -5461 +5461 @@
         // Sub-sizes: for each size, the JPEGs should be smaller than the WebP.
         $sizes_to_compare = array_intersect_key( $jpeg_sizes['sizes'], $webp_sizes['sizes'] );
+
+        $this->assertNotEmpty( $sizes_to_compare );
+
         foreach ( $sizes_to_compare as $size => $size_data ) {
             $this->assertLessThan( $webp_sizes['sizes'][ $size ]['filesize'], $jpeg_sizes['sizes'][ $size ]['filesize'] );
@@ -5470 +5473 @@
      *
      * @ticket 61614
+     *
+     * Temporarily disabled until we can figure out why it fails on the Trixie based PHP container.
+     * See https://core.trac.wordpress.org/ticket/63932.
+     * @requires PHP < 8.3
      */
     public function test_quality_with_avif_conversion_file_sizes() {
@@ -5503 +5510 @@
         // Sub-sizes: for each size, the AVIF should be smaller than the JPEG.
         $sizes_to_compare = array_intersect_key( $avif_sizes['sizes'], $smaller_avif_sizes['sizes'] );
+
+        $this->assertNotEmpty( $sizes_to_compare );
 
         foreach ( $sizes_to_compare as $size => $size_data ) {