Changeset 60736 for trunk/tests/phpunit/tests/image/resize.php

Timestamp:

09/13/2025 12:14:39 PM (3 months ago)

Author:

johnbillion

Message:

Media: Temporarily disable failing tests when Imagick 7 is in use, pending further investigation.

The updated PHP 8.4 and 8.3 containers are running Imagick 7 which is producing some test failures for AVIFs and PNGs with 1-bit transparency. This requires further investigation, possibly accompanied by more comprehensive testing across Imagick versions, so these tests are disabled for now.

Additional missing assertions have also been added which ensure an unexpected WP_Error instance correctly fails the test and is not passed to an image processing function.

Props johnbillion, siliconforks, desrosj, jorbin.

See #63932

File:

• trunk/tests/phpunit/tests/image/resize.php (modified) (12 diffs)

trunk/tests/phpunit/tests/image/resize.php

@@ -24 +24 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/test-image.jpg', 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -79 +81 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -93 +97 @@
      *
      * @ticket 51228
+     *
+     * Temporarily disabled until we can figure out why it fails on the Trixie based PHP container.
+     * See https://core.trac.wordpress.org/ticket/63932.
+     * @requires PHP < 8.3
      */
     public function test_resize_avif() {
@@ -105 +113 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -131 +141 @@
         $image = $this->resize_helper( $file, 25, 25 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = wp_getimagesize( $image );
 
@@ -152 +164 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 128, 96 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -165 +179 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 128, 0 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -178 +194 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 0, 96 );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -191 +209 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 150, 150, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -204 +224 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 150, 100, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -217 +239 @@
         $image = $this->resize_helper( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG', 50, 150, true );
 
+        $this->assertNotWPError( $image );
+
         list( $w, $h, $type ) = getimagesize( $image );
 
@@ -241 +265 @@
     /**
      * Function to help out the tests
+     *
+     * @return string|WP_Error The path to the resized image file or a WP_Error on failure.
      */
     protected function resize_helper( $file, $width, $height, $crop = false ) {