Changeset 60775

Timestamp:

09/17/2025 05:46:39 AM (12 months ago)

Author:

westonruter

Message:

Menus: Fix searchability of post types which contain numeric characters.

The regular expression needs to correspond to how a post type slug is sanitized by sanitize_key() in register_post_type().

Props kshaner, mindctrl, oglekler.
Fixes #63633.

Location:

trunk

Files:

• src/wp-admin/includes/nav-menu.php (modified) (1 diff)
• tests/phpunit/tests/menu/wpAjaxMenuQuickSearch.php (modified) (1 diff)

trunk/src/wp-admin/includes/nav-menu.php

@@ -81 +81 @@
                         }
                 }
-        } elseif ( preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z_-]*\b)/', $type, $matches ) ) {
+        } elseif ( preg_match( '/quick-search-(posttype|taxonomy)-([a-zA-Z0-9_-]*\b)/', $type, $matches ) ) {
                 if ( 'posttype' === $matches[1] && get_post_type_object( $matches[2] ) ) {
                         $post_type_obj = _wp_nav_menu_meta_box_object( get_post_type_object( $matches[2] ) );

trunk/tests/phpunit/tests/menu/wpAjaxMenuQuickSearch.php

@@ -122 +122 @@
                 $this->assertCount( 1, $results );
         }
+
+        /**
+         * Test that search displays results for post types with numeric slugs
+         *
+         * @ticket 63633
+         */
+        public function test_search_returns_post_types_with_numeric_slugs() {
+                register_post_type( 'wptests_123' );
+
+                self::factory()->post->create(
+                        array(
+                                'post_title'   => 'Post Title 123',
+                                'post_type'    => 'wptests_123',
+                                'post_status'  => 'publish',
+                                'post_content' => 'FOO',
+                        )
+                );
+
+                $request = array(
+                        'type' => 'quick-search-posttype-wptests_123',
+                        'q'    => 'FOO',
+                );
+
+                $output = get_echo( '_wp_ajax_menu_quick_search', array( $request ) );
+                $this->assertNotEmpty( $output );
+
+                $results = explode( "\n", trim( $output ) );
+                $this->assertCount( 1, $results );
+
+                $results_json = array_map( 'json_decode', $results );
+                $this->assertEquals( 'wptests_123', $results_json[0]->post_type );
+        }
 }