Changeset 60789

Timestamp:

09/21/2025 03:50:56 PM (12 months ago)

Author:

SergeyBiryukov

Message:

Database: Do not unnecessarily alter table in dbDelta() for field type case differences.

This aims to avoid extra changes to database structure when type case is the only difference:

Changed type of wp_table.field from varchar(255) to VARCHAR(255)

Follow-up to [1575], [37532].

Props leewillis77, tristanleboss, lordspace, johnbillion, SergeyBiryukov.
Fixes #59481.

Location:

trunk

Files:

• src/wp-admin/includes/upgrade.php (modified) (1 diff)
• tests/phpunit/tests/db/dbDelta.php (modified) (1 diff)

trunk/src/wp-admin/includes/upgrade.php

@@ -3204 +3204 @@
 
                                 // Is actual field type different from the field type in query?
-                                if ( $tablefield->Type !== $fieldtype ) {
+                                if ( $tablefield->Type !== $fieldtype_lowercased ) {
                                         $do_change = true;
                                         if ( in_array( $fieldtype_lowercased, $text_fields, true ) && in_array( $tablefield_type_lowercased, $text_fields, true ) ) {

trunk/tests/phpunit/tests/db/dbDelta.php

@@ -1117 +1117 @@
                 );
         }
+
+        /**
+         * @ticket 59481
+         */
+        public function test_column_types_are_not_case_sensitive() {
+                global $wpdb;
+
+                $updates = dbDelta(
+                        "
+                        CREATE TABLE {$wpdb->prefix}dbdelta_test (
+                                id bigint(20) NOT NULL AUTO_INCREMENT,
+                                column_1 varCHAr(255) NOT NULL,
+                                column_2 TEXT,
+                                column_3 blOB,
+                                PRIMARY KEY  (id),
+                                KEY key_1 (column_1($this->max_index_length)),
+                                KEY compound_key (id,column_1($this->max_index_length)),
+                                FULLTEXT KEY fulltext_key (column_1)
+                        ) {$this->db_engine}
+                        ",
+                        false
+                );
+
+                $this->assertEmpty( $updates );
+        }
 }