Changeset 60800

Timestamp:

09/26/2025 09:08:52 PM (12 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Move specific sniff exclusions for getID3 to the config file.

This aims to make future updates of the library easier.

Follow-up to [47735], [47737], [47902].

See #63168.

Location:

trunk

Files:

• phpcompat.xml.dist (modified) (1 diff)
• src/wp-includes/ID3/getid3.php (modified) (4 diffs)
• src/wp-includes/ID3/module.audio-video.quicktime.php (modified) (1 diff)

trunk/phpcompat.xml.dist

@@ -77 +77 @@
         -->
 
+        <rule ref="PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDeprecatedRemoved">
+                <exclude-pattern>/ID3/getid3\.php$</exclude-pattern>
+        </rule>
         <rule ref="PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated">
+                <exclude-pattern>/ID3/getid3\.php$</exclude-pattern>
                 <exclude-pattern>/PHPMailer/PHPMailer\.php$</exclude-pattern>
+        </rule>
+        <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_runtimeDeprecated">
+                <exclude-pattern>/ID3/getid3\.php$</exclude-pattern>
+        </rule>
+        <rule ref="PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_gpcDeprecated">
+                <exclude-pattern>/ID3/getid3\.php$</exclude-pattern>
+        </rule>
+        <rule ref="PHPCompatibility.Lists.AssignmentOrder.Affected">
+                <exclude-pattern>/ID3/module.audio-video.quicktime\.php$</exclude-pattern>
         </rule>
         <rule ref="PHPCompatibility.Constants.RemovedConstants.intl_idna_variant_2003Deprecated">

trunk/src/wp-includes/ID3/getid3.php

@@ -426 +426 @@
 
                 // Check safe_mode off
-                if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) { // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDeprecatedRemoved
+                if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) {
                         $this->warning('WARNING: Safe mode is on, shorten support disabled, md5data/sha1data for ogg vorbis disabled, ogg vorbos/flac tag writing disabled.');
                 }
 
-                // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated
                 if (($mbstring_func_overload = (int) ini_get('mbstring.func_overload')) && ($mbstring_func_overload & 0x02)) {
                         // http://php.net/manual/en/mbstring.overload.php
                         // "mbstring.func_overload in php.ini is a positive value that represents a combination of bitmasks specifying the categories of functions to be overloaded. It should be set to 1 to overload the mail() function. 2 for string functions, 4 for regular expression functions"
                         // getID3 cannot run when string functions are overloaded. It doesn't matter if mail() or ereg* functions are overloaded since getID3 does not use those.
-                        // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.mbstring_func_overloadDeprecated
                         $this->startup_error .= 'WARNING: php.ini contains "mbstring.func_overload = '.ini_get('mbstring.func_overload').'", getID3 cannot run with this setting (bitmask 2 (string functions) cannot be set). Recommended to disable entirely.'."\n";
                 }
@@ -443 +441 @@
                         // Check for magic_quotes_runtime
                         if (function_exists('get_magic_quotes_runtime')) {
-                                // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_runtimeDeprecated
                                 if (get_magic_quotes_runtime()) { // @phpstan-ignore-line
                                         $this->startup_error .= 'magic_quotes_runtime must be disabled before running getID3(). Surround getid3 block by set_magic_quotes_runtime(0) and set_magic_quotes_runtime(1).'."\n";
@@ -450 +447 @@
                         // Check for magic_quotes_gpc
                         if (function_exists('get_magic_quotes_gpc')) {
-                                // phpcs:ignore PHPCompatibility.FunctionUse.RemovedFunctions.get_magic_quotes_gpcDeprecated
                                 if (get_magic_quotes_gpc()) { // @phpstan-ignore-line
                                         $this->startup_error .= 'magic_quotes_gpc must be disabled before running getID3(). Surround getid3 block by set_magic_quotes_gpc(0) and set_magic_quotes_gpc(1).'."\n";
@@ -1791 +1787 @@
                         // currently vorbiscomment only works on OggVorbis files.
 
-                        // phpcs:ignore PHPCompatibility.IniDirectives.RemovedIniDirectives.safe_modeDeprecatedRemoved
                         if (preg_match('#(1|ON)#i', ini_get('safe_mode'))) {
 

trunk/src/wp-includes/ID3/module.audio-video.quicktime.php

@@ -145 +145 @@
                                 $ISO6709parsed = array('latitude'=>false, 'longitude'=>false, 'altitude'=>false);
                                 if (preg_match('#^([\\+\\-])([0-9]{2}|[0-9]{4}|[0-9]{6})(\\.[0-9]+)?([\\+\\-])([0-9]{3}|[0-9]{5}|[0-9]{7})(\\.[0-9]+)?(([\\+\\-])([0-9]{3}|[0-9]{5}|[0-9]{7})(\\.[0-9]+)?)?/$#', $ISO6709string, $matches)) {
-                                        // phpcs:ignore PHPCompatibility.Lists.AssignmentOrder.Affected
                                         @list($dummy, $lat_sign, $lat_deg, $lat_deg_dec, $lon_sign, $lon_deg, $lon_deg_dec, $dummy, $alt_sign, $alt_deg, $alt_deg_dec) = $matches;