Changeset 60805 for trunk/src/wp-admin/includes/class-custom-background.php

Timestamp:

09/28/2025 10:36:30 PM (3 months ago)

Author:

joedolson

Message:

I18n: Combine duplicate text strings into variables.

In cases where a string is used both for a visible label and a screen reader text label, the screen reader text should never be different from the visible label. To help ensure this doesn't happen, use only a single string. The associated screen reader text comments are no longer required.

This is also true for a few cases where there are strings in contexts where variables can't be used. In these cases, the screen reader text comments are also removed.

Props sabernhardt, swissspidy, audrasjb, joedolson.
Fixes #63620.

File:

• trunk/src/wp-admin/includes/class-custom-background.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-custom-background.php

@@ -378 +378 @@
 
             <?php
+            $background_position_title = __( 'Image Position' );
+
             $background_position = sprintf(
                 '%s %s',
@@ -430 +432 @@
             ?>
 <tr>
-<th scope="row"><?php _e( 'Image Position' ); ?></th>
-<td><fieldset><legend class="screen-reader-text"><span>
-            <?php
-            /* translators: Hidden accessibility text. */
-            _e( 'Image Position' );
-            ?>
-</span></legend>
+<th scope="row"><?php echo $background_position_title; ?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $background_position_title; ?></span></legend>
 <div class="background-position-control">
             <?php foreach ( $background_position_options as $group ) : ?>
@@ -453 +450 @@
 </tr>
 
-<tr>
-<th scope="row"><label for="background-size"><?php _e( 'Image Size' ); ?></label></th>
-<td><fieldset><legend class="screen-reader-text"><span>
-            <?php
-            /* translators: Hidden accessibility text. */
-            _e( 'Image Size' );
-            ?>
-</span></legend>
+            <?php $image_size_title = __( 'Image Size' ); ?>
+<tr>
+<th scope="row"><label for="background-size"><?php echo $image_size_title; ?></label></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $image_size_title; ?></span></legend>
 <select id="background-size" name="background-size">
 <option value="auto"<?php selected( 'auto', get_theme_mod( 'background_size', get_theme_support( 'custom-background', 'default-size' ) ) ); ?>><?php _ex( 'Original', 'Original Size' ); ?></option>
@@ -469 +462 @@
 </tr>
 
-<tr>
-<th scope="row"><?php _ex( 'Repeat', 'Background Repeat' ); ?></th>
-<td><fieldset><legend class="screen-reader-text"><span>
-            <?php
-            /* translators: Hidden accessibility text. */
-            _ex( 'Repeat', 'Background Repeat' );
-            ?>
-</span></legend>
+            <?php $background_repeat_title = _x( 'Repeat', 'Background Repeat' ); ?>
+<tr>
+<th scope="row"><?php echo $background_repeat_title; ?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $background_repeat_title; ?></span></legend>
 <input name="background-repeat" type="hidden" value="no-repeat">
 <label><input type="checkbox" name="background-repeat" value="repeat"<?php checked( 'repeat', get_theme_mod( 'background_repeat', get_theme_support( 'custom-background', 'default-repeat' ) ) ); ?>> <?php _e( 'Repeat Background Image' ); ?></label>
@@ -482 +471 @@
 </tr>
 
-<tr>
-<th scope="row"><?php _ex( 'Scroll', 'Background Scroll' ); ?></th>
-<td><fieldset><legend class="screen-reader-text"><span>
-            <?php
-            /* translators: Hidden accessibility text. */
-            _ex( 'Scroll', 'Background Scroll' );
-            ?>
-</span></legend>
+            <?php $background_scroll_title = _x( 'Scroll', 'Background Scroll' ); ?>
+<tr>
+<th scope="row"><?php echo $background_scroll_title; ?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $background_scroll_title; ?></span></legend>
 <input name="background-attachment" type="hidden" value="fixed">
 <label><input name="background-attachment" type="checkbox" value="scroll" <?php checked( 'scroll', get_theme_mod( 'background_attachment', get_theme_support( 'custom-background', 'default-attachment' ) ) ); ?>> <?php _e( 'Scroll with Page' ); ?></label>
@@ -495 +480 @@
 </tr>
 <?php endif; // get_background_image() ?>
-<tr>
-<th scope="row"><?php _e( 'Background Color' ); ?></th>
-<td><fieldset><legend class="screen-reader-text"><span>
-        <?php
-        /* translators: Hidden accessibility text. */
-        _e( 'Background Color' );
-        ?>
-</span></legend>
+
+        <?php $background_color_title = __( 'Background Color' ); ?>
+<tr>
+<th scope="row"><?php echo $background_color_title; ?></th>
+<td><fieldset><legend class="screen-reader-text"><span><?php echo $background_color_title; ?></span></legend>
         <?php
         $default_color = '';