Changeset 60805 for trunk/src/wp-admin/install.php

Timestamp:

09/28/2025 10:36:30 PM (11 months ago)

Author:

joedolson

Message:

I18n: Combine duplicate text strings into variables.

In cases where a string is used both for a visible label and a screen reader text label, the screen reader text should never be different from the visible label. To help ensure this doesn't happen, use only a single string. The associated screen reader text comments are no longer required.

This is also true for a few cases where there are strings in contexts where variables can't be used. In these cases, the screen reader text comments are also removed.

Props sabernhardt, swissspidy, audrasjb, joedolson.
Fixes #63620.

File:

• trunk/src/wp-admin/install.php (modified) (1 diff)

trunk/src/wp-admin/install.php

@@ -181 +181 @@
                         <p id="admin-email-desc"><?php _e( 'Double-check your email address before continuing.' ); ?></p></td>
                 </tr>
+                <?php $blog_privacy_selector_title = has_action( 'blog_privacy_selector' ) ? __( 'Site visibility' ) : __( 'Search engine visibility' ); ?>
                 <tr>
-                        <th scope="row"><?php has_action( 'blog_privacy_selector' ) ? _e( 'Site visibility' ) : _e( 'Search engine visibility' ); ?></th>
+                        <th scope="row"><?php echo $blog_privacy_selector_title; ?></th>
                         <td>
                                 <fieldset>
-                                        <legend class="screen-reader-text"><span>
-                                                <?php
-                                                has_action( 'blog_privacy_selector' )
-                                                        /* translators: Hidden accessibility text. */
-                                                        ? _e( 'Site visibility' )
-                                                        /* translators: Hidden accessibility text. */
-                                                        : _e( 'Search engine visibility' );
-                                                ?>
-                                        </span></legend>
+                                        <legend class="screen-reader-text"><span><?php echo $blog_privacy_selector_title; ?></span></legend>
                                         <?php
                                         if ( has_action( 'blog_privacy_selector' ) ) {