Changeset 60805 for trunk/src/wp-admin/network/settings.php

Timestamp:

09/28/2025 10:36:30 PM (2 months ago)

Author:

joedolson

Message:

I18n: Combine duplicate text strings into variables.

In cases where a string is used both for a visible label and a screen reader text label, the screen reader text should never be different from the visible label. To help ensure this doesn't happen, use only a single string. The associated screen reader text comments are no longer required.

This is also true for a few cases where there are strings in contexts where variables can't be used. In these cases, the screen reader text comments are also removed.

Props sabernhardt, swissspidy, audrasjb, joedolson.
Fixes #63620.

File:

• trunk/src/wp-admin/network/settings.php (modified) (3 diffs)

trunk/src/wp-admin/network/settings.php

@@ -200 +200 @@
         <h2><?php _e( 'Registration Settings' ); ?></h2>
         <table class="form-table" role="presentation">
-            <tr>
-                <th scope="row"><?php _e( 'Allow new registrations' ); ?></th>
+            <?php $new_registrations_settings_title = __( 'Allow new registrations' ); ?>
+            <tr>
+                <th scope="row"><?php echo $new_registrations_settings_title; ?></th>
                 <?php
                 if ( ! get_site_option( 'registration' ) ) {
@@ -210 +211 @@
                 <td>
                     <fieldset>
-                    <legend class="screen-reader-text">
-                        <?php
-                        /* translators: Hidden accessibility text. */
-                        _e( 'New registrations settings' );
-                        ?>
-                    </legend>
+                    <legend class="screen-reader-text"><?php echo $new_registrations_settings_title; ?></legend>
                     <label><input name="registration" type="radio" id="registration1" value="none"<?php checked( $reg, 'none' ); ?> /> <?php _e( 'Registration is disabled' ); ?></label><br />
                     <label><input name="registration" type="radio" id="registration2" value="user"<?php checked( $reg, 'user' ); ?> /> <?php _e( 'User accounts may be registered' ); ?></label><br />
@@ -511 +507 @@
             <h2><?php _e( 'Menu Settings' ); ?></h2>
             <table id="menu" class="form-table">
+                <?php $enable_administration_menus_title = __( 'Enable administration menus' ); ?>
                 <tr>
-                    <th scope="row"><?php _e( 'Enable administration menus' ); ?></th>
+                    <th scope="row"><?php echo $enable_administration_menus_title; ?></th>
                     <td>
                         <?php
-                        echo '<fieldset><legend class="screen-reader-text">' .
-                            /* translators: Hidden accessibility text. */
-                            __( 'Enable menus' ) .
-                        '</legend>';
+                        echo '<fieldset><legend class="screen-reader-text">' . $enable_administration_menus_title . '</legend>';
 
                         foreach ( (array) $menu_items as $key => $val ) {