Changeset 60805 for trunk/src/wp-admin/options-reading.php

Timestamp:

09/28/2025 10:36:30 PM (2 months ago)

Author:

joedolson

Message:

I18n: Combine duplicate text strings into variables.

In cases where a string is used both for a visible label and a screen reader text label, the screen reader text should never be different from the visible label. To help ensure this doesn't happen, use only a single string. The associated screen reader text comments are no longer required.

This is also true for a few cases where there are strings in contexts where variables can't be used. In these cases, the screen reader text comments are also removed.

Props sabernhardt, swissspidy, audrasjb, joedolson.
Fixes #63620.

File:

• trunk/src/wp-admin/options-reading.php (modified) (3 diffs)

trunk/src/wp-admin/options-reading.php

@@ -82 +82 @@
         update_option( 'show_on_front', 'posts' );
     }
+
+    $your_homepage_displays_title = __( 'Your homepage displays' );
     ?>
 <table class="form-table" role="presentation">
 <tr>
-<th scope="row"><?php _e( 'Your homepage displays' ); ?></th>
+<th scope="row"><?php echo $your_homepage_displays_title; ?></th>
 <td id="front-static-pages"><fieldset>
-    <legend class="screen-reader-text"><span>
-        <?php
-        /* translators: Hidden accessibility text. */
-        _e( 'Your homepage displays' );
-        ?>
-    </span></legend>
+    <legend class="screen-reader-text"><span><?php echo $your_homepage_displays_title; ?></span></legend>
     <p><label>
         <input name="show_on_front" type="radio" value="posts" class="tog" <?php checked( 'posts', get_option( 'show_on_front' ) ); ?> />
@@ -180 +177 @@
 <td><input name="posts_per_rss" type="number" step="1" min="1" id="posts_per_rss" value="<?php form_option( 'posts_per_rss' ); ?>" class="small-text" /> <?php _e( 'items' ); ?></td>
 </tr>
-<tr>
-<th scope="row"><?php _e( 'For each post in a feed, include' ); ?> </th>
+
+<?php $rss_use_excerpt_title = __( 'For each post in a feed, include' ); ?>
+<tr>
+<th scope="row"><?php echo $rss_use_excerpt_title; ?> </th>
 <td><fieldset>
-    <legend class="screen-reader-text"><span>
-        <?php
-        /* translators: Hidden accessibility text. */
-        _e( 'For each post in a feed, include' );
-        ?>
-    </span></legend>
+    <legend class="screen-reader-text"><span><?php echo $rss_use_excerpt_title; ?></span></legend>
     <p>
         <label><input name="rss_use_excerpt" type="radio" value="0" <?php checked( 0, get_option( 'rss_use_excerpt' ) ); ?> /> <?php _e( 'Full text' ); ?></label><br />
@@ -205 +199 @@
 </tr>
 
+<?php $blog_privacy_selector_title = has_action( 'blog_privacy_selector' ) ? __( 'Site visibility' ) : __( 'Search engine visibility' ); ?>
 <tr class="option-site-visibility">
-<th scope="row"><?php has_action( 'blog_privacy_selector' ) ? _e( 'Site visibility' ) : _e( 'Search engine visibility' ); ?> </th>
+<th scope="row"><?php echo $blog_privacy_selector_title; ?> </th>
 <td><fieldset>
-    <legend class="screen-reader-text"><span>
-        <?php
-        has_action( 'blog_privacy_selector' )
-            /* translators: Hidden accessibility text. */
-            ? _e( 'Site visibility' )
-            /* translators: Hidden accessibility text. */
-            : _e( 'Search engine visibility' );
-        ?>
-    </span></legend>
+    <legend class="screen-reader-text"><span><?php echo $blog_privacy_selector_title; ?></span></legend>
 <?php if ( has_action( 'blog_privacy_selector' ) ) : ?>
     <input id="blog-public" type="radio" name="blog_public" value="1" <?php checked( '1', get_option( 'blog_public' ) ); ?> />