Changeset 60806 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

09/28/2025 11:38:57 PM (7 weeks ago)

Author:

joedolson

Message:

A11y: Ensure icons are not spoken by screen readers.

For all CSS generated icons across core, either add aria-hidden="true" to the HTML wrapper or set the generated content alternative to an empty string in the CSS using the alternative text specification for CSS generated content.

Props afercia, joedolson, cheffheid, jhabdas.
Fixes #40428.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -1077 +1077 @@
                 }
 
-                $failures[ $library ] = "<span class='dashicons $class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
+                $failures[ $library ] = "<span class='dashicons $class' aria-hidden='true'></span><span class='screen-reader-text'>$screen_reader</span> $message";
             }
         }
@@ -2441 +2441 @@
 
         if ( empty( $page_cache_detail['response_time'] ) ) {
-            $page_cache_test_summary[] = '<span class="dashicons dashicons-dismiss"></span> ' . __( 'Server response time could not be determined. Verify that loopback requests are working.' );
+            $page_cache_test_summary[] = '<span class="dashicons dashicons-dismiss" aria-hidden="true"></span> ' . __( 'Server response time could not be determined. Verify that loopback requests are working.' );
         } else {
 
             $threshold = $this->get_good_response_time_threshold();
             if ( $page_cache_detail['response_time'] < $threshold ) {
-                $page_cache_test_summary[] = '<span class="dashicons dashicons-yes-alt"></span> ' . sprintf(
+                $page_cache_test_summary[] = '<span class="dashicons dashicons-yes-alt" aria-hidden="true"></span> ' . sprintf(
                     /* translators: 1: The response time in milliseconds, 2: The recommended threshold in milliseconds. */
                     __( 'Median server response time was %1$s milliseconds. This is less than the recommended %2$s milliseconds threshold.' ),
@@ -2453 +2453 @@
                 );
             } else {
-                $page_cache_test_summary[] = '<span class="dashicons dashicons-warning"></span> ' . sprintf(
+                $page_cache_test_summary[] = '<span class="dashicons dashicons-warning" aria-hidden="true"></span> ' . sprintf(
                     /* translators: 1: The response time in milliseconds, 2: The recommended threshold in milliseconds. */
                     __( 'Median server response time was %1$s milliseconds. It should be less than the recommended %2$s milliseconds threshold.' ),
@@ -2462 +2462 @@
 
             if ( empty( $page_cache_detail['headers'] ) ) {
-                $page_cache_test_summary[] = '<span class="dashicons dashicons-warning"></span> ' . __( 'No client caching response headers were detected.' );
+                $page_cache_test_summary[] = '<span class="dashicons dashicons-warning" aria-hidden="true"></span> ' . __( 'No client caching response headers were detected.' );
             } else {
-                $headers_summary  = '<span class="dashicons dashicons-yes-alt"></span>';
+                $headers_summary  = '<span class="dashicons dashicons-yes-alt" aria-hidden="true"></span>';
                 $headers_summary .= ' ' . sprintf(
                     /* translators: %d: Number of caching headers. */
@@ -2480 +2480 @@
 
         if ( $page_cache_detail['advanced_cache_present'] ) {
-            $page_cache_test_summary[] = '<span class="dashicons dashicons-yes-alt"></span> ' . __( 'A page cache plugin was detected.' );
+            $page_cache_test_summary[] = '<span class="dashicons dashicons-yes-alt" aria-hidden="true"></span> ' . __( 'A page cache plugin was detected.' );
         } elseif ( ! ( is_array( $page_cache_detail ) && ! empty( $page_cache_detail['headers'] ) ) ) {
             // Note: This message is not shown if client caching response headers were present since an external caching layer may be employed.
-            $page_cache_test_summary[] = '<span class="dashicons dashicons-warning"></span> ' . __( 'A page cache plugin was not detected.' );
+            $page_cache_test_summary[] = '<span class="dashicons dashicons-warning" aria-hidden="true"></span> ' . __( 'A page cache plugin was not detected.' );
         }