Changeset 60812

Timestamp:

09/29/2025 07:11:01 PM (10 months ago)

Author:

swissspidy

Message:

External Libraries: Backport upstream PHP 8.5 fixes for getID3.

In absence of a new release, this cherry-picks ​8cb29233 and ​dbda40de.

Props swissspidy, vidugupta, TobiasBg, desrosj.
Fixes #64051. See #63061.

Location:

trunk/src/wp-includes/ID3

Files:

• getid3.lib.php (modified) (1 diff)
• getid3.php (modified) (3 diffs)
• module.audio.ogg.php (modified) (3 diffs)

trunk/src/wp-includes/ID3/getid3.lib.php

@@ -1789 +1789 @@
                 }
                 if (isset($commandline)) {
-                        $output = trim(`$commandline`);
+                        $output = trim(shell_exec($commandline));
                         if (ctype_digit($output)) {
                                 $filesize = (float) $output;

trunk/src/wp-includes/ID3/getid3.php

@@ -482 +482 @@
                                                 if (!empty($path_so_far)) {
                                                         $commandline = 'dir /x '.escapeshellarg(implode(DIRECTORY_SEPARATOR, $path_so_far));
-                                                        $dir_listing = `$commandline`;
+                                                        $dir_listing = shell_exec($commandline);
                                                         $lines = explode("\n", $dir_listing);
                                                         foreach ($lines as $line) {
@@ -1810 +1810 @@
 
                                                 $commandline = '"'.GETID3_HELPERAPPSDIR.'vorbiscomment.exe" -w -c "'.$empty.'" "'.$file.'" "'.$temp.'"';
-                                                $VorbisCommentError = `$commandline`;
+                                                $VorbisCommentError = shell_exec($commandline);
 
                                         } else {
@@ -1821 +1821 @@
 
                                         $commandline = 'vorbiscomment -w -c '.escapeshellarg($empty).' '.escapeshellarg($file).' '.escapeshellarg($temp).' 2>&1';
-                                        $VorbisCommentError = `$commandline`;
+                                        $VorbisCommentError = shell_exec($commandline);
 
                                 }

trunk/src/wp-includes/ID3/module.audio.ogg.php

@@ -788 +788 @@
                                         case 'rg_audiophile':
                                         case 'replaygain_album_gain':
-                                                $info['replay_gain']['album']['adjustment'] = (double) $commentvalue[0];
+                                                $info['replay_gain']['album']['adjustment'] = (float) $commentvalue[0];
                                                 unset($info['ogg']['comments'][$index]);
                                                 break;
@@ -794 +794 @@
                                         case 'rg_radio':
                                         case 'replaygain_track_gain':
-                                                $info['replay_gain']['track']['adjustment'] = (double) $commentvalue[0];
+                                                $info['replay_gain']['track']['adjustment'] = (float) $commentvalue[0];
                                                 unset($info['ogg']['comments'][$index]);
                                                 break;
 
                                         case 'replaygain_album_peak':
-                                                $info['replay_gain']['album']['peak'] = (double) $commentvalue[0];
+                                                $info['replay_gain']['album']['peak'] = (float) $commentvalue[0];
                                                 unset($info['ogg']['comments'][$index]);
                                                 break;
@@ -805 +805 @@
                                         case 'rg_peak':
                                         case 'replaygain_track_peak':
-                                                $info['replay_gain']['track']['peak'] = (double) $commentvalue[0];
+                                                $info['replay_gain']['track']['peak'] = (float) $commentvalue[0];
                                                 unset($info['ogg']['comments'][$index]);
                                                 break;
 
                                         case 'replaygain_reference_loudness':
-                                                $info['replay_gain']['reference_volume'] = (double) $commentvalue[0];
+                                                $info['replay_gain']['reference_volume'] = (float) $commentvalue[0];
                                                 unset($info['ogg']['comments'][$index]);
                                                 break;