Changeset 60815 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

09/30/2025 04:26:44 PM (10 months ago)

Author:

johnbillion

Message:

Menus: Prevent HTML in menu item titles from being rendered unexpectedly.

Props audrasjb, desrosj, johnbillion, jorbin, phillsav, vortfu, westonruter

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -192 +192 @@
                         } elseif ( 'post' !== $object_name && 0 === $page && $post_type->has_archive ) {
                                 // Add a post type archive link.
+                                $title   = $post_type->labels->archives;
                                 $items[] = array(
-                                        'id'         => $object_name . '-archive',
-                                        'title'      => $post_type->labels->archives,
-                                        'type'       => 'post_type_archive',
-                                        'type_label' => __( 'Post Type Archive' ),
-                                        'object'     => $object_name,
-                                        'url'        => get_post_type_archive_link( $object_name ),
+                                        'id'             => $object_name . '-archive',
+                                        'title'          => $title,
+                                        'original_title' => $title,
+                                        'type'           => 'post_type_archive',
+                                        'type_label'     => __( 'Post Type Archive' ),
+                                        'object'         => $object_name,
+                                        'url'            => get_post_type_archive_link( $object_name ),
                                 );
                         }
@@ -245 +247 @@
                                 }
 
+                                $title   = html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) );
                                 $items[] = array(
-                                        'id'         => "post-{$post->ID}",
-                                        'title'      => html_entity_decode( $post_title, ENT_QUOTES, get_bloginfo( 'charset' ) ),
-                                        'type'       => 'post_type',
-                                        'type_label' => $post_type_label,
-                                        'object'     => $post->post_type,
-                                        'object_id'  => (int) $post->ID,
-                                        'url'        => get_permalink( (int) $post->ID ),
+                                        'id'             => "post-{$post->ID}",
+                                        'title'          => $title,
+                                        'original_title' => $title,
+                                        'type'           => 'post_type',
+                                        'type_label'     => $post_type_label,
+                                        'object'         => $post->post_type,
+                                        'object_id'      => (int) $post->ID,
+                                        'url'            => get_permalink( (int) $post->ID ),
                                 );
                         }
@@ -277 +281 @@
 
                         foreach ( $terms as $term ) {
+                                $title   = html_entity_decode( $term->name, ENT_QUOTES, get_bloginfo( 'charset' ) );
                                 $items[] = array(
-                                        'id'         => "term-{$term->term_id}",
-                                        'title'      => html_entity_decode( $term->name, ENT_QUOTES, get_bloginfo( 'charset' ) ),
-                                        'type'       => 'taxonomy',
-                                        'type_label' => get_taxonomy( $term->taxonomy )->labels->singular_name,
-                                        'object'     => $term->taxonomy,
-                                        'object_id'  => (int) $term->term_id,
-                                        'url'        => get_term_link( (int) $term->term_id, $term->taxonomy ),
+                                        'id'             => "term-{$term->term_id}",
+                                        'title'          => $title,
+                                        'original_title' => $title,
+                                        'type'           => 'taxonomy',
+                                        'type_label'     => get_taxonomy( $term->taxonomy )->labels->singular_name,
+                                        'object'         => $term->taxonomy,
+                                        'object_id'      => (int) $term->term_id,
+                                        'url'            => get_term_link( (int) $term->term_id, $term->taxonomy ),
                                 );
                         }