Changeset 60815 for trunk/tests/phpunit/tests/customize/nav-menus.php

Timestamp:

09/30/2025 04:26:44 PM (6 months ago)

Author:

johnbillion

Message:

Menus: Prevent HTML in menu item titles from being rendered unexpectedly.

Props audrasjb, desrosj, johnbillion, jorbin, phillsav, vortfu, westonruter

File:

• trunk/tests/phpunit/tests/customize/nav-menus.php (modified) (6 diffs)

trunk/tests/phpunit/tests/customize/nav-menus.php

@@ -185 +185 @@
         // Expected menu item array.
         $expected = array(
-            'id'         => "post-{$post_id}",
-            'title'      => 'Post Title',
-            'type'       => 'post_type',
-            'type_label' => 'Post',
-            'object'     => 'post',
-            'object_id'  => (int) $post_id,
-            'url'        => get_permalink( (int) $post_id ),
+            'id'             => "post-{$post_id}",
+            'title'          => 'Post Title',
+            'original_title' => 'Post Title',
+            'type'           => 'post_type',
+            'type_label'     => 'Post',
+            'object'         => 'post',
+            'object_id'      => (int) $post_id,
+            'url'            => get_permalink( (int) $post_id ),
         );
 
@@ -217 +218 @@
         // Expected menu item array.
         $expected = array(
-            'id'         => "post-{$page_id}",
-            'title'      => 'Page Title',
-            'type'       => 'post_type',
-            'type_label' => 'Page',
-            'object'     => 'page',
-            'object_id'  => (int) $page_id,
-            'url'        => get_permalink( (int) $page_id ),
+            'id'             => "post-{$page_id}",
+            'title'          => 'Page Title',
+            'original_title' => 'Page Title',
+            'type'           => 'post_type',
+            'type_label'     => 'Page',
+            'object'         => 'page',
+            'object_id'      => (int) $page_id,
+            'url'            => get_permalink( (int) $page_id ),
         );
 
@@ -243 +245 @@
         // Expected menu item array.
         $expected = array(
-            'id'         => "post-{$post_id}",
-            'title'      => 'Post Title',
-            'type'       => 'post_type',
-            'type_label' => 'Post',
-            'object'     => 'post',
-            'object_id'  => (int) $post_id,
-            'url'        => get_permalink( (int) $post_id ),
+            'id'             => "post-{$post_id}",
+            'title'          => 'Post Title',
+            'original_title' => 'Post Title',
+            'type'           => 'post_type',
+            'type_label'     => 'Post',
+            'object'         => 'post',
+            'object_id'      => (int) $post_id,
+            'url'            => get_permalink( (int) $post_id ),
         );
 
@@ -269 +272 @@
         // Expected menu item array.
         $expected = array(
-            'id'         => "term-{$term_id}",
-            'title'      => 'Term Title',
-            'type'       => 'taxonomy',
-            'type_label' => 'Category',
-            'object'     => 'category',
-            'object_id'  => (int) $term_id,
-            'url'        => get_term_link( (int) $term_id, 'category' ),
+            'id'             => "term-{$term_id}",
+            'title'          => 'Term Title',
+            'original_title' => 'Term Title',
+            'type'           => 'taxonomy',
+            'type_label'     => 'Category',
+            'object'         => 'category',
+            'object_id'      => (int) $term_id,
+            'url'            => get_term_link( (int) $term_id, 'category' ),
         );
 
@@ -786 +790 @@
         $this->assertNotEmpty( $post_types );
 
-        foreach ( $post_types as $type ) {
-            $this->assertStringContainsString( 'available-menu-items-post_type-' . esc_attr( $type->name ), $template );
-            $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $type->labels->name ) . '#', $template );
-            $this->assertStringContainsString( 'data-type="post_type"', $template );
-            $this->assertStringContainsString( 'data-object="' . esc_attr( $type->name ) . '"', $template );
-            $this->assertStringContainsString( 'data-type_label="' . esc_attr( $type->labels->singular_name ) . '"', $template );
+            foreach ( $post_types as $type ) {
+                $this->assertStringContainsString( 'available-menu-items-post_type-' . esc_attr( $type->name ), $template );
+                $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $type->labels->name ) . '#', $template );
+                $this->assertStringContainsString( 'data-type="post_type"', $template );
+                $this->assertStringContainsString( 'data-object="' . esc_attr( $type->name ) . '"', $template );
+                $this->assertStringContainsString( 'data-type_label="' . esc_attr( $type->labels->singular_name ) . '"', $template );
         }
 
@@ -798 +802 @@
         $this->assertNotEmpty( $taxonomies );
 
-        foreach ( $taxonomies as $tax ) {
-            $this->assertStringContainsString( 'available-menu-items-taxonomy-' . esc_attr( $tax->name ), $template );
-            $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $tax->labels->name ) . '#', $template );
-            $this->assertStringContainsString( 'data-type="taxonomy"', $template );
-            $this->assertStringContainsString( 'data-object="' . esc_attr( $tax->name ) . '"', $template );
-            $this->assertStringContainsString( 'data-type_label="' . esc_attr( $tax->labels->singular_name ) . '"', $template );
+            foreach ( $taxonomies as $tax ) {
+                $this->assertStringContainsString( 'available-menu-items-taxonomy-' . esc_attr( $tax->name ), $template );
+                $this->assertMatchesRegularExpression( '#<h4 class="accordion-section-title".*>\s*<button type="button" class="accordion-trigger" aria-expanded="false" aria-controls=".*">\s*' . esc_html( $tax->labels->name ) . '#', $template );
+                $this->assertStringContainsString( 'data-type="taxonomy"', $template );
+                $this->assertStringContainsString( 'data-object="' . esc_attr( $tax->name ) . '"', $template );
+                $this->assertStringContainsString( 'data-type_label="' . esc_attr( $tax->labels->singular_name ) . '"', $template );
         }